Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1127333004: Remove release-mode assert that has out-stayed its welcome (Closed)

Created:
5 years, 7 months ago by Erik Corry Chromium.org
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove release-mode assert that has out-stayed its welcome R=hpayer@chromium.org BUG= Committed: https://crrev.com/d989a25770acf8994235e7f4c36f11700537fae9 Cr-Commit-Position: refs/heads/master@{#28425}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M src/heap/mark-compact.h View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Erik Corry Chromium.org
5 years, 7 months ago (2015-05-15 14:05:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127333004/1
5 years, 7 months ago (2015-05-15 14:06:08 UTC) #3
Hannes Payer (out of office)
lgtm
5 years, 7 months ago (2015-05-15 14:07:51 UTC) #4
Hannes Payer (out of office)
lgtm
5 years, 7 months ago (2015-05-15 14:08:09 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-15 14:37:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127333004/1
5 years, 7 months ago (2015-05-15 14:47:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 14:48:22 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 14:48:35 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d989a25770acf8994235e7f4c36f11700537fae9
Cr-Commit-Position: refs/heads/master@{#28425}

Powered by Google App Engine
This is Rietveld 408576698