LayoutTests/svg/animations/animation-begin-change-js.html - Issue 1127313007: SVG animate element's begin/end attribute set by js, should animate.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/animations/animation-begin-change-js.html

Issue 1127313007: SVG animate element's begin/end attribute set by js, should animate. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: small nits Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Tests that animation works, if begin is set by js.</title>
	fs 2015/05/12 10:35:48 Try to make this describe the test better (it's ve Try to make this describe the test better (it's very generic in its current form.) Shanmuga Pandi 2015/05/12 11:03:10 Done. Show quoted text On 2015/05/12 10:35:48, fs wrote: > Try to make this describe the test better (it's very generic in its current > form.) Done.
	3 <script src=../../resources/testharness.js></script>

	4 <script src=../../resources/testharnessreport.js></script>

	5 <svg>

	6 <rect id="rect" width="100" height="100">

	7 <set id="anim"

	8 begin="indefinite"

	9 dur="0.05s"

	10 attributeName="width"

	11 to="50"

	12 fill="freeze"/>

	13 </rect>

	14 </svg>

	15 <script>

	16 document.getElementById("anim").setAttribute("begin","rect.click");

	17 if (window.eventSender) {

	18 eventSender.mouseMoveTo(50, 50);

	19 eventSender.mouseDown();

	20 eventSender.mouseUp();

	21 }

	22

	23 if (window.testRunner) {

	24 testRunner.displayAsyncThen(function() {

	25 dumpResult();

	26 });

	27 }

	28

	29 function dumpResult()

	30 {

	31 var width = document.getElementById("rect").getAttribute("width");

	32 test(function() {

	33 assert_not_equals(width, "100");
	fs 2015/05/12 10:35:48 This is very atypical use of testharness I'd say. This is very atypical use of testharness I'd say. This would be better structured as an async_test. Using the 'begin' event I think it would look something like: var anim = ...; var t = async_test("Changing 'begin' to contain an event-base trigger."); anim.onbegin = t.step_func(function() { assert_equals(document.getElementById("rect").getAttribute("width"), 100); t.done(); }); anim.setAttribute(...); <dispatch click> No access to testRunner should be needed at all. Shanmuga Pandi 2015/05/12 11:03:10 Changed according to your suggestion. Thank you. Show quoted text On 2015/05/12 10:35:48, fs wrote: > This is very atypical use of testharness I'd say. This would be better > structured as an async_test. Using the 'begin' event I think it would look > something like: > > var anim = ...; > var t = async_test("Changing 'begin' to contain an event-base trigger."); > anim.onbegin = t.step_func(function() { > assert_equals(document.getElementById("rect").getAttribute("width"), 100); > t.done(); > }); > > anim.setAttribute(...); > <dispatch click> > > No access to testRunner should be needed at all. Changed according to your suggestion. Thank you.
	34 }, document.title);

	35

	36 if (window.testRunner)

	37 testRunner.notifyDone();

	38 }

	39

	40 if (window.testRunner) {

	41 testRunner.dumpAsText();

	42 testRunner.waitUntilDone();

	43 }

	44 </script>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/svg/animation/SVGSMILElement.cpp » ('j') | no next file with comments »