LayoutTests/svg/animations/animation-begin-change-js.html - Issue 1127313007: SVG animate element's begin/end attribute set by js, should animate.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/animations/animation-begin-change-js.html

Issue 1127313007: SVG animate element's begin/end attribute set by js, should animate. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <svg>

	3 <rect id="rect" x="0" width="100px" height="100px" fill='orange'>
	fs 2015/05/11 15:41:53 x="0" and fill='orange' doesn't appear to be neede x="0" and fill='orange' doesn't appear to be needed. Shanmuga Pandi 2015/05/12 09:43:13 Done. Show quoted text On 2015/05/11 15:41:53, fs wrote: > x="0" and fill='orange' doesn't appear to be needed. Done.
	4 <animate id="anim"
	fs 2015/05/11 15:41:53 Can you use a <set> instead? Can you use a <set> instead? Shanmuga Pandi 2015/05/12 09:43:14 Done. Show quoted text On 2015/05/11 15:41:53, fs wrote: > Can you use a <set> instead? Done.
	5 begin="infinite"
	fs 2015/05/11 15:41:53 indefinite? indefinite? Shanmuga Pandi 2015/05/12 09:43:14 Acknowledged. Show quoted text On 2015/05/11 15:41:53, fs wrote: > indefinite? Acknowledged.
	6 dur="2s"

	7 attributeName="x"

	8 to="50"

	9 fill="freeze"/>

	10 </rect>

	11 <text y="150" x="20" id="console"/>
	fs 2015/05/11 15:41:53 Looks unnecessary. Looks unnecessary. Shanmuga Pandi 2015/05/12 09:43:14 Done. Show quoted text On 2015/05/11 15:41:53, fs wrote: > Looks unnecessary. Done.
	12 </svg>

	13 <script>

	14 document.getElementById("anim").setAttribute("begin","rect.click");

	15 setTimeout(Test, 0);

	16 function Test() {
	fs 2015/05/11 15:41:53 Could just use an anonymous function() directly in Could just use an anonymous function() directly in setTimeout. Why is the setTimeout even needed though? Shanmuga Pandi 2015/05/12 09:43:14 Done. Show quoted text On 2015/05/11 15:41:53, fs wrote: > Could just use an anonymous function() directly in setTimeout. Why is the > setTimeout even needed though? Done.
	17 if (window.eventSender) {

	18 eventSender.mouseMoveTo(50, 50);

	19 eventSender.mouseDown();

	20 eventSender.mouseUp();

	21 }

	22

	23 if (window.testRunner) {

	24 testRunner.displayAsyncThen(function() {
	fs 2015/05/11 15:41:53 Ought to be possible to run this on the 'begin' ev Ought to be possible to run this on the 'begin' event instead. Shanmuga Pandi 2015/05/12 09:43:13 begin event will not be triggered with out this pa Show quoted text On 2015/05/11 15:41:53, fs wrote: > Ought to be possible to run this on the 'begin' event instead. begin event will not be triggered with out this patch. So with out this patch, timeout occurs. So I keep it same
	25 dumpResult();

	26 });

	27 }

	28 }

	29

	30 function dumpResult()

	31 {

	32 var console = document.getElementById("console");

	33 var x = document.getElementById("rect").getAttribute("x");

	34 if (x == 0)

	35 console.appendChild(document.createTextNode("Failed (x was not anima ted)"));

	36 else

	37 console.appendChild(document.createTextNode("Passed"));

	38 if (window.testRunner)

	39 testRunner.notifyDone();

	40 }

	41

	42 if (window.testRunner) {

	43 testRunner.dumpAsText();

	44 testRunner.waitUntilDone();

	45 }

	46

	47 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/animations/animation-begin-change-js-expected.txt » ('j') | no next file with comments »