Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 1127313005: Revert of Add the concept of a V8 extras exports object (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
CC:
Paweł Hajdan Jr., v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Add the concept of a V8 extras exports object (patchset #5 id:80001 of https://codereview.chromium.org/1128113006/) Reason for revert: [Sheriff] Causes gc stress failures: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20gc%20stress/builds/2167 Original issue's description: > Add the concept of a V8 extras exports object > > Exposed to the extras as extrasExports (on the builtins object), on > which they can put things that should be accessible from C++. Exposed > to C++ through the V8 API as v8::Context::GetExtrasExportsObject(). > > Adding a test (in test-api.cc) required adding a simple extra, > test-extra.js, which we build into the standalone builds. > > R=yangguo@chromium.org, jochen@chromium.org > BUG= > > Committed: https://crrev.com/ad547cea05f3e02c67243b682e933fc53ac763d9 > Cr-Commit-Position: refs/heads/master@{#28317} TBR=jochen@chromium.org,yangguo@chromium.org,domenic@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/19a28dcefd941f3a38c15695111827d7da74dbd2 Cr-Commit-Position: refs/heads/master@{#28332}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -73 lines) Patch
M build/standalone.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M include/v8.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/bootstrapper.cc View 3 chunks +0 lines, -16 lines 0 comments Download
M src/contexts.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-test.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D test/cctest/test-extra.js View 1 chunk +0 lines, -11 lines 0 comments Download
M test/mjsunit/debug-script.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Add the concept of a V8 extras exports object
5 years, 7 months ago (2015-05-11 08:19:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127313005/1
5 years, 7 months ago (2015-05-11 08:19:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 08:20:06 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 08:20:21 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/19a28dcefd941f3a38c15695111827d7da74dbd2
Cr-Commit-Position: refs/heads/master@{#28332}

Powered by Google App Engine
This is Rietveld 408576698