runtime/vm/hash_map_test.cc - Issue 11273111: Allow bound check elimination to eliminate checks when both array length and index boundaries are e…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/hash_map_test.cc

Issue 11273111: Allow bound check elimination to eliminate checks when both array length and index boundaries are e… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: address Florian's comments Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/hash_map_test.cc

diff --git a/runtime/vm/hash_map_test.cc b/runtime/vm/hash_map_test.cc

index a5b4afef41b4efce9ba1dd34c90fb38ea3ace832..522ff7c57ddc18d740f9dc733197631ba127b5d2 100644

--- a/runtime/vm/hash_map_test.cc

+++ b/runtime/vm/hash_map_test.cc

@@ -19,7 +19,7 @@ class TestValue {

TEST_CASE(DirectChainedHashMap) {

- DirectChainedHashMap<TestValue*> map;

+ DirectChainedHashMap<PointerKeyValueTrait<TestValue> > map;

EXPECT(map.IsEmpty());

TestValue v1(0);

TestValue v2(1);

@@ -30,7 +30,7 @@ TEST_CASE(DirectChainedHashMap) {

EXPECT(map.Lookup(&v1) == &v1);

EXPECT(map.Lookup(&v2) == &v2);

EXPECT(map.Lookup(&v3) == &v1);

- DirectChainedHashMap<TestValue*> map2(map);

+ DirectChainedHashMap<PointerKeyValueTrait<TestValue> > map2(map);

EXPECT(map2.Lookup(&v1) == &v1);

EXPECT(map2.Lookup(&v2) == &v2);

EXPECT(map2.Lookup(&v3) == &v1);

« no previous file with comments | « runtime/vm/hash_map.h ('k') | runtime/vm/intermediate_language.h » ('j') | no next file with comments »