Restart app before running monkey test.

Restart app before running monkey test.

Also remove dependency on env variables during import of apk_info.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165022

[bulach, 2012-10-30 10:52:50]

thanks frank! some small suggestions below:

https://codereview.chromium.org/11273099/diff/1/build/android/pylib/android_c...
File build/android/pylib/android_commands.py (right):

https://codereview.chromium.org/11273099/diff/1/build/android/pylib/android_c...
build/android/pylib/android_commands.py:509: force_stop=False,
wait_for_completion=False,
nit: new default params should always be added at the end, otherwise callers
will (potentially) start passing the wrong params..

https://codereview.chromium.org/11273099/diff/1/build/android/run_monkey_test.py
File build/android/run_monkey_test.py (right):

https://codereview.chromium.org/11273099/diff/1/build/android/run_monkey_test...
build/android/run_monkey_test.py:14: # Don't need these deps.
hmm, which bit needs this?
would it be possible to just set this where it's needed, then reset to the old
value afterwards?
it seems unsafe to modify environment variables like this.

something like:
  try:
    old_sdk_root = os.environ.get('ANDROID_SDK_ROOT')
    old_build_top = os.environ.get('ANDROID_BUILD_TOP')
    os.environ['ANDROID_SDK_ROOT'] = ''
    os.environ['ANDROID_BUILD_TOP'] = ''
    DoWhatever()
  finally:
    os.environ['ANDROID_SDK_ROOT'] = old_sdk_root
    os.environ['ANDROID_BUILD_TOP'] = old_build_top

[frankf, 2012-10-30 19:05:21]

PTAL.

http://codereview.chromium.org/11273099/diff/1/build/android/pylib/android_co...
File build/android/pylib/android_commands.py (right):

http://codereview.chromium.org/11273099/diff/1/build/android/pylib/android_co...
build/android/pylib/android_commands.py:509: force_stop=False,
wait_for_completion=False,
Done.

On 2012/10/30 10:52:50, bulach wrote:
> nit: new default params should always be added at the end, otherwise callers
> will (potentially) start passing the wrong params..

http://codereview.chromium.org/11273099/diff/1/build/android/run_monkey_test.py
File build/android/run_monkey_test.py (right):

http://codereview.chromium.org/11273099/diff/1/build/android/run_monkey_test....
build/android/run_monkey_test.py:14: # Don't need these deps.
Good point. I fixed the root cause by moving class constants in apk_info so
there's no look up during import.

On 2012/10/30 10:52:50, bulach wrote:
> hmm, which bit needs this?
> would it be possible to just set this where it's needed, then reset to the old
> value afterwards?
> it seems unsafe to modify environment variables like this.
> 
> something like:
>   try:
>     old_sdk_root = os.environ.get('ANDROID_SDK_ROOT')
>     old_build_top = os.environ.get('ANDROID_BUILD_TOP')
>     os.environ['ANDROID_SDK_ROOT'] = ''
>     os.environ['ANDROID_BUILD_TOP'] = ''
>     DoWhatever()
>   finally:
>     os.environ['ANDROID_SDK_ROOT'] = old_sdk_root
>     os.environ['ANDROID_BUILD_TOP'] = old_build_top
>

[bulach, 2012-10-30 19:18:12]

lgtm, thanks!

[klundberg, 2012-10-30 19:24:14]

lgtm