Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11273064: Issue 5887. Parts must start with 'part of'. (Closed)

Created:
8 years, 1 month ago by scheglov
Modified:
8 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 5887. Parts must start with 'part of'. Second attempt. Now only DartC changes, and status updates. So, should not break anyone else. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=14217

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+933 lines, -1031 lines) Patch
M compiler/java/com/google/dart/compiler/DartCompiler.java View 2 chunks +35 lines, -20 lines 0 comments Download
M compiler/java/com/google/dart/compiler/DartCompilerErrorCode.java View 1 chunk +6 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/DeltaAnalyzer.java View 2 chunks +6 lines, -1 line 0 comments Download
M compiler/java/com/google/dart/compiler/resolver/Scope.java View 1 chunk +0 lines, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/CodeCompletionParseTest.java View 6 chunks +6 lines, -6 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/CompilerTestCase.java View 3 chunks +8 lines, -10 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/DeltaAnalyzerTest.java View 6 chunks +36 lines, -20 lines 0 comments Download
D compiler/javatests/com/google/dart/compiler/IdeTest.java View 1 chunk +0 lines, -270 lines 0 comments Download
D compiler/javatests/com/google/dart/compiler/IdeTests.java View 1 chunk +0 lines, -24 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java View 35 chunks +135 lines, -16 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/MemoryLibrarySource.java View 3 chunks +24 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/my.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/my.app.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/my.merged.app.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/my.no5ref.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/my.nuke5.app.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/my.prefixed.app.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/my.unprefixed.app.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/mybase.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/mybase.no5ref.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.fillthehole.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.fillthemethodhole.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.fillthenothole.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.globalfunctionchange.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.globalvarchange.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.newstaticmethod.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother0.returntypechange.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother1.dart View 1 chunk +1 line, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother1.change.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother2.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother2.change.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother3.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother3.newstaticfield.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother34.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother4.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother4.change.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother4.newstaticfield.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother5.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother5.change.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother6.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother6.change.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother6.removeclass.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/myother7.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/some.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/some.intfchange.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/some.newmethod.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/someimpl.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/someimpl.bodychange.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/end2end/inc/someimpl.change.dart View 1 chunk +1 line, -0 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/resolver/ResolverCompilerTest.java View 9 chunks +34 lines, -48 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 64 chunks +238 lines, -349 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/Library.java View 2 chunks +6 lines, -4 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/AnalysisServerTest.java View 3 chunks +8 lines, -8 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/FileChangedTaskTest.java View 4 chunks +93 lines, -91 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/ScanTaskTest.java View 4 chunks +30 lines, -24 lines 4 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/test_data/Money/complex_money.dart View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/test_data/Money/currency.dart View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/test_data/Money/currency_exchange.dart View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core_test/test_data/Money/money.dart View 1 chunk +1 line, -1 line 1 comment Download
M editor/tools/plugins/com.google.dart.tools.core_test/test_data/Money/simple_money.dart View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/cleanup/migration/Migrate_1M1_library_CleanUp.java View 1 chunk +1 line, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/correction/QuickFixProcessorTest.java View 2 chunks +2 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameFieldProcessorTest.java View 4 chunks +22 lines, -22 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameFunctionProcessorTest.java View 2 chunks +15 lines, -15 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameFunctionTypeAliasProcessorTest.java View 3 chunks +20 lines, -17 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameGlobalVariableProcessorTest.java View 3 chunks +20 lines, -17 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameImportProcessorTest.java View 4 chunks +21 lines, -18 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameMethodProcessorTest.java View 4 chunks +22 lines, -22 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui_test/src/com/google/dart/tools/ui/refactoring/RenameTypeProcessorTest.java View 2 chunks +22 lines, -22 lines 0 comments Download
M pkg/pkg.status View 1 chunk +24 lines, -0 lines 0 comments Download
M samples/tests/samples/samples.status View 2 chunks +5 lines, -0 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +22 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
8 years, 1 month ago (2012-10-27 21:49:05 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/11273064/diff/1/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/ScanTaskTest.java File editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/ScanTaskTest.java (right): https://codereview.chromium.org/11273064/diff/1/editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/ScanTaskTest.java#newcode23 editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/ScanTaskTest.java:23: import com.google.common.collect.Lists; We're still getting formatting noise. We ...
8 years, 1 month ago (2012-10-29 14:23:47 UTC) #2
scheglov
8 years, 1 month ago (2012-10-29 19:18:51 UTC) #3 
https://codereview.chromium.org/11273064/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/ScanTaskTest.java
(right):

https://codereview.chromium.org/11273064/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/ScanTaskTest.java:23:
import com.google.common.collect.Lists;
On 2012/10/29 14:23:47, Brian Wilkerson wrote:
> We're still getting formatting noise. We really need to figure out why and
stop
> this.

I will reimport imports order settings.
It seems to fix this formatting.

https://codereview.chromium.org/11273064/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.tools.core_test/src/com/google/dart/tools/core/analysis/ScanTaskTest.java:56:
* TODO(scheglov) disabled because now 'part of' directive required
On 2012/10/29 14:23:47, Brian Wilkerson wrote:
> Is there any point in keeping these tests?

Not much, but I want to open issue for Dan to review and decide.

Powered by Google App Engine
This is Rietveld 408576698