Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1127293004: Revert of Fix WebViewPlugin::scheduleAnimation crash (Closed)

Created:
5 years, 7 months ago by trchen
Modified:
5 years, 7 months ago
Reviewers:
tommycli, raymes
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix WebViewPlugin::scheduleAnimation crash (patchset #2 id:20001 of https://codereview.chromium.org/1137663006/) Reason for revert: This is converting the original crash to another crash. Will need another null check. Original issue's description: > Fix WebViewPlugin::scheduleAnimation crash > > The crash was probably due to accessing a dangling pointer to the plugin > container during a small time frame between PepperWebPluginImpl::destroy() > and the destructor being called. (Speculated from source since no reliable > repro is found.) > > This CL clears eveything in the destroy() function as if the destructor has > been called, only delaying memory release. > > R=tommycli > BUG=483068 > > Committed: https://crrev.com/6a9b5b10ff3515adb47718fc23ebe039a9e3b9ff > Cr-Commit-Position: refs/heads/master@{#329309} TBR=tommycli@chromium.org,raymes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=487607, 483068 Committed: https://crrev.com/5f4832367a1f3bd00e84037e2f77ed02af5bf23e Cr-Commit-Position: refs/heads/master@{#329715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
trchen
Created Revert of Fix WebViewPlugin::scheduleAnimation crash
5 years, 7 months ago (2015-05-13 21:07:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127293004/1
5 years, 7 months ago (2015-05-13 21:08:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127293004/1
5 years, 7 months ago (2015-05-13 21:10:32 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 21:10:40 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 21:11:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5f4832367a1f3bd00e84037e2f77ed02af5bf23e
Cr-Commit-Position: refs/heads/master@{#329715}

Powered by Google App Engine
This is Rietveld 408576698