Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1127283003: Make some file_system_provider_capabilities fields optional. (Closed)

Created:
5 years, 7 months ago by mtomasz
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make some file_system_provider_capabilities fields optional. The "configurable" and "multipleMounts" should be optional and default to false. TEST=browser_tests: *FileSystemProvider*Configure*, *FileSystemProvider*Mount* BUG=474146 Committed: https://crrev.com/142ae9d4b0c8e37610b59d0a808c93cceb3dc569 Cr-Commit-Position: refs/heads/master@{#329558}

Patch Set 1 #

Patch Set 2 : Fixed parsing. #

Total comments: 2

Patch Set 3 : Cleaned up. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -51 lines) Patch
M chrome/browser/chromeos/file_system_provider/service.cc View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider_capabilities/file_system_provider_capabilities_handler.cc View 1 1 chunk +8 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/manifest_types.json View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/add_watcher/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/big_file/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/configure/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/copy_entry/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/create_directory/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/create_file/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/delete_entry/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/evil/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/extension/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/get_all/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/get_metadata/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/mime_type/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/mount/manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/move_entry/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/notify/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_directory/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/read_file/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/remove_watcher/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/thumbnail/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/truncate/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/unmount/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/file_system_provider/write_file/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtomasz
@kalman: PTAL. Thanks.
5 years, 7 months ago (2015-05-12 06:49:39 UTC) #3
not at google - send to devlin
lgtm https://codereview.chromium.org/1127283003/diff/40001/chrome/browser/chromeos/file_system_provider/service.cc File chrome/browser/chromeos/file_system_provider/service.cc (right): https://codereview.chromium.org/1127283003/diff/40001/chrome/browser/chromeos/file_system_provider/service.cc#newcode321 chrome/browser/chromeos/file_system_provider/service.cc:321: const auto capabilities = (I preferred it as ...
5 years, 7 months ago (2015-05-12 20:52:14 UTC) #4
mtomasz
https://codereview.chromium.org/1127283003/diff/40001/chrome/browser/chromeos/file_system_provider/service.cc File chrome/browser/chromeos/file_system_provider/service.cc (right): https://codereview.chromium.org/1127283003/diff/40001/chrome/browser/chromeos/file_system_provider/service.cc#newcode321 chrome/browser/chromeos/file_system_provider/service.cc:321: const auto capabilities = On 2015/05/12 20:52:14, kalman wrote: ...
5 years, 7 months ago (2015-05-13 00:29:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127283003/60001
5 years, 7 months ago (2015-05-13 00:31:07 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 7 months ago (2015-05-13 01:34:55 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 01:35:54 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/142ae9d4b0c8e37610b59d0a808c93cceb3dc569
Cr-Commit-Position: refs/heads/master@{#329558}

Powered by Google App Engine
This is Rietveld 408576698