Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1127263004: Use the same version of Chrome Connectivity Diagnostics for Kiosk mode (Closed)

Created:
5 years, 7 months ago by Zachary Kuznia
Modified:
5 years, 7 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, dzhioev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the same version of Chrome Connectivity Diagnostics for Kiosk mode BUG=487365 Committed: https://crrev.com/ddb33388a663c8c362f0b815ee47dd7de1b12e62 Cr-Commit-Position: refs/heads/master@{#329685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/chromeos/login/screens/error_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_constants.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_constants.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Zachary Kuznia
kalman: Could you take a look at: chrome/common/extensions/extension_constants.{cc,h} dpolukhin: Could you take a look at: ...
5 years, 7 months ago (2015-05-12 19:15:37 UTC) #2
not at google - send to devlin
happy to rubberstamp lgtm the constants
5 years, 7 months ago (2015-05-13 01:28:03 UTC) #3
Dmitry Polukhin
lgtm
5 years, 7 months ago (2015-05-13 04:58:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127263004/1
5 years, 7 months ago (2015-05-13 17:54:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 18:50:24 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 18:51:16 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ddb33388a663c8c362f0b815ee47dd7de1b12e62
Cr-Commit-Position: refs/heads/master@{#329685}

Powered by Google App Engine
This is Rietveld 408576698