Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1127253002: Revert "cc: Remove Tile refcounting and RefCountedManaged." (Closed)

Created:
5 years, 7 months ago by Derek Bruening
Modified:
5 years, 7 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "cc: Remove Tile refcounting and RefCountedManaged." This reverts commit 6d440ed4fc458fae27397b868acb4ab2866119b1. Reason for revert: Breaks the build_for_tool=drmemory Windows build: http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Windows%20Builder%20%28DrMemory%29/builds/12393 TBR=vmpstr@chromium.org NOTRY=true BUG=none Committed: https://crrev.com/edfd2bff088cb1de353d9b6fae609e86b53cd2ed Cr-Commit-Position: refs/heads/master@{#328607}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -68 lines) Patch
M cc/base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A cc/base/ref_counted_managed.h View 1 chunk +65 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cc/debug/rasterize_and_record_benchmark_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/resources/picture_layer_tiling.h View 5 chunks +14 lines, -8 lines 0 comments Download
M cc/resources/picture_layer_tiling.cc View 5 chunks +12 lines, -13 lines 0 comments Download
M cc/resources/picture_layer_tiling_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/resources/tile.h View 5 chunks +4 lines, -9 lines 0 comments Download
M cc/resources/tile.cc View 2 chunks +1 line, -6 lines 0 comments Download
M cc/resources/tile_manager.h View 4 chunks +12 lines, -10 lines 0 comments Download
M cc/resources/tile_manager.cc View 1 chunk +11 lines, -10 lines 0 comments Download
M cc/test/fake_picture_layer_tiling_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/test/fake_picture_layer_tiling_client.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Derek Bruening
5 years, 7 months ago (2015-05-06 20:54:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127253002/1
5 years, 7 months ago (2015-05-06 20:55:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-06 21:00:28 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 21:01:22 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/edfd2bff088cb1de353d9b6fae609e86b53cd2ed
Cr-Commit-Position: refs/heads/master@{#328607}

Powered by Google App Engine
This is Rietveld 408576698