Issue 1127233009: Perform a display configuration in software mirror on hotplug event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1127233009: Perform a display configuration in software mirror on hotplug event (Closed)

Created:
5 years, 7 months ago by dnicoara

Modified:
5 years, 7 months ago

Reviewers:

CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2403

Target Ref:
refs/pending/branch-heads/2403

Project:
chromium

Visibility:
Public.

More Reviews

Description

Perform a display configuration in software mirror on hotplug event On a hotplug event we configure the displays regardless of the state. However if we're in software mirror mode the configuration was skipped if the previous configuration was extended mode. We want to have a consistent approach to display configuration, so make sure we configure the displays if the configuration was triggered by a system event. Otherwise (if the configuration was requested by the user) we'll just skip the configuration so we don't perform unnecessary modesets. BUG=488736 Review URL: https://codereview.chromium.org/1133743005 Cr-Commit-Position: refs/heads/master@{#330534} (cherry picked from commit 1559e6b945b7c0d24c6d3f79a6c6dd811690fc4c) Committed: https://chromium.googlesource.com/chromium/src/+/423044fb9e9c0889f73ce329c017a13f5fa03351

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -2 lines)			Patch
	M	ui/display/chromeos/update_display_configuration_task.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	ui/display/chromeos/update_display_configuration_task_unittest.cc	View		4 chunks	+103 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

dnicoara

5 years, 7 months ago (2015-05-19 21:47:45 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
423044fb9e9c0889f73ce329c017a13f5fa03351.

Expand Messages | Collapse Messages