build/download_gold_plugin.py - Issue 1127233002: Use Clang's update.py --print-revision everywhere.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/download_gold_plugin.py

Issue 1127233002: Use Clang's update.py --print-revision everywhere. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Set 'shell=True' when running 'svn info' Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/download_gold_plugin.py

diff --git a/build/download_gold_plugin.py b/build/download_gold_plugin.py

index 1d8be5a25760c02b2982d6fb1a1b2ce41eab8e00..cd7ca41ed312fe7774b622d163a8700e366b0bde 100755

--- a/build/download_gold_plugin.py

+++ b/build/download_gold_plugin.py

@@ -23,9 +23,9 @@ GSUTIL_PATH = os.path.join(DEPOT_PATH, 'gsutil.py')

LLVM_BUILD_PATH = os.path.join(CHROME_SRC, 'third_party', 'llvm-build',

'Release+Asserts')

-CLANG_UPDATE_SH = os.path.join(CHROME_SRC, 'tools', 'clang', 'scripts',

- 'update.sh')

-CLANG_REVISION = os.popen(CLANG_UPDATE_SH + ' --print-revision').read().rstrip()

+CLANG_UPDATE_PY = os.path.join(CHROME_SRC, 'tools', 'clang', 'scripts',

+ 'update.py')

+CLANG_REVISION = os.popen(CLANG_UPDATE_PY + ' --print-revision').read().rstrip()

CLANG_BUCKET = 'gs://chromium-browser-clang/Linux_x64'

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | tools/clang/scripts/posix-print-revision.py » ('j') | no next file with comments »