Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 1127213005: [Android WebView] Add auto-grant permissions to WebViewShell. (Closed)

Created:
5 years, 7 months ago by timvolodine
Modified:
5 years, 7 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android WebView] Add auto-grant permissions to WebViewShell. Grant certain permissions like video and audio capture in the WebViewShell mini-browser automatically. This is necessary to be able to test WebRTC functionality. BUG=481508 Committed: https://crrev.com/887a102d6acd7f0012b88605edb4eda8526e101d Cr-Commit-Position: refs/heads/master@{#329647}

Patch Set 1 #

Patch Set 2 : simpify grant logic #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M android_webview/tools/WebViewShell/AndroidManifest.xml View 1 chunk +3 lines, -0 lines 0 comments Download
M android_webview/tools/WebViewShell/src/org/chromium/webview_shell/WebViewBrowserActivity.java View 1 3 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
timvolodine
5 years, 7 months ago (2015-05-13 14:21:09 UTC) #2
timvolodine
torne@: as you suggested I've uploaded a new patch with simplified logic for granting requests.
5 years, 7 months ago (2015-05-13 15:08:17 UTC) #3
Torne
lgtm
5 years, 7 months ago (2015-05-13 15:10:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127213005/20001
5 years, 7 months ago (2015-05-13 16:05:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-13 16:11:11 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 16:12:12 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/887a102d6acd7f0012b88605edb4eda8526e101d
Cr-Commit-Position: refs/heads/master@{#329647}

Powered by Google App Engine
This is Rietveld 408576698