Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 11272036: Fixing threading issues in remoting::DesktopProcess. The UI thread is now owned by the caller of re… (Closed)

Created:
8 years, 1 month ago by alexeypa (please no reviews)
Modified:
8 years, 1 month ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, timurrrr+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, glider+watch_chromium.org, sergeyu+watch_chromium.org, bruening+watch_chromium.org, Brad Chen (chromium)
Visibility:
Public.

Description

Fixing threading issues in remoting::DesktopProcess. The UI thread is now owned by the caller of remoting::DesktopThread so it can be properly shared between the caller and the class. BUG=157808, 157886 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164243

Patch Set 1 #

Total comments: 2

Patch Set 2 : CR feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -99 lines) Patch
M remoting/host/desktop_process.h View 4 chunks +10 lines, -3 lines 0 comments Download
M remoting/host/desktop_process.cc View 2 chunks +47 lines, -48 lines 0 comments Download
M remoting/host/desktop_process_main.cc View 1 2 chunks +24 lines, -2 lines 0 comments Download
M remoting/host/desktop_process_unittest.cc View 1 9 chunks +51 lines, -29 lines 0 comments Download
M tools/valgrind/gtest_exclude/remoting_unittests.gtest-drmemory_win32.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alexeypa (please no reviews)
PTAL.
8 years, 1 month ago (2012-10-25 18:17:31 UTC) #1
Sergey Ulanov
LGTM once my comment is addressed. http://codereview.chromium.org/11272036/diff/1/remoting/host/desktop_process_main.cc File remoting/host/desktop_process_main.cc (right): http://codereview.chromium.org/11272036/diff/1/remoting/host/desktop_process_main.cc#newcode89 remoting/host/desktop_process_main.cc:89: FROM_HERE, MessageLoop::QuitClosure()); this ...
8 years, 1 month ago (2012-10-25 20:29:31 UTC) #2
alexeypa (please no reviews)
Thanks. http://codereview.chromium.org/11272036/diff/1/remoting/host/desktop_process_main.cc File remoting/host/desktop_process_main.cc (right): http://codereview.chromium.org/11272036/diff/1/remoting/host/desktop_process_main.cc#newcode89 remoting/host/desktop_process_main.cc:89: FROM_HERE, MessageLoop::QuitClosure()); On 2012/10/25 20:29:32, sergeyu wrote: > ...
8 years, 1 month ago (2012-10-25 20:36:21 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-10-25 20:37:56 UTC) #4

Powered by Google App Engine
This is Rietveld 408576698