Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1127203004: Add GYP targets for mojo shell and some basic mojo services (Closed)

Created:
5 years, 7 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add GYP targets for mojo shell and some basic mojo services BUG=None R=jam@chromium.org Committed: https://crrev.com/7c94aa5c0738d9b3bfa852100a264f010b16dfc8 Cr-Commit-Position: refs/heads/master@{#330387}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -1 line) Patch
M mojo/mojo_base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A mojo/mojo_services.gyp View 1 chunk +48 lines, -0 lines 0 comments Download
A mojo/mojo_shell.gyp View 1 chunk +79 lines, -0 lines 0 comments Download
M third_party/mojo/mojom_bindings_generator_explicit.gypi View 3 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Ken Rockot(use gerrit already)
These have been broken out of a larger CL which will soon need them.
5 years, 7 months ago (2015-05-16 03:34:16 UTC) #1
jam
lgtm
5 years, 7 months ago (2015-05-18 15:48:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127203004/1
5 years, 7 months ago (2015-05-18 17:37:05 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 20:14:03 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:41:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c94aa5c0738d9b3bfa852100a264f010b16dfc8
Cr-Commit-Position: refs/heads/master@{#330387}

Powered by Google App Engine
This is Rietveld 408576698