Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Unified Diff: tools/bots/compiler.py

Issue 11272017: Expand buildbot checks for both ie9 and ie10. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bots/compiler.py
===================================================================
--- tools/bots/compiler.py (revision 14033)
+++ tools/bots/compiler.py (working copy)
@@ -86,7 +86,7 @@
def NeedsXterm(compiler, runtime):
- return runtime in ['ie', 'chrome', 'safari', 'opera', 'ff', 'drt']
+ return runtime in ['ie9', 'ie10', 'chrome', 'safari', 'opera', 'ff', 'drt']
def TestStepName(name, flags):
@@ -142,7 +142,7 @@
- test_set: Specification of a non standard test set, default None
"""
- if system.startswith('win') and runtime == 'ie':
+ if system.startswith('win') and runtime.startswith('ie'):
# There should not be more than one InternetExplorerDriver instance
# running at a time. For details, see
# http://code.google.com/p/selenium/wiki/InternetExplorerDriver.
@@ -195,7 +195,7 @@
# that run the browser tests to cut down on the cycle time.
TestStep("dart2js_unit", mode, system, 'none', 'vm', ['dart2js'], flags)
- if not (system.startswith('win') and runtime == 'ie'):
+ if not (system.startswith('win') and runtime.startswith('ie')):
# Run the default set of test suites.
TestStep("dart2js", mode, system, 'dart2js', runtime, [], flags)
@@ -260,7 +260,7 @@
# vms for testing this.
if (build_info.system == 'linux' and build_info.runtime == 'chrome'):
return True
- if (build_info.system == 'win7' and build_info.runtime == 'ie' and
+ if (build_info.system == 'win7' and build_info.runtime.startswith('ie') and
build_info.test_set == 'all'):
return True
return False
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698