tesselating path renderer unit tests

tesselating path renderer unit tests

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/2fbd4068bde6a9fb50341c0bdfbb8bf18b70d015

[joshualitt, 2015-05-07 15:35:35]

joshualitt@google.com changed reviewers:
+ bsalomon@google.com, joshualitt@google.com, robertphillips@google.com

[joshualitt, 2015-05-07 15:35:36]

ptal, Brian for API

[robertphillips, 2015-05-07 16:59:30]

Questions

https://codereview.chromium.org/1127183006/diff/1/src/gpu/GrTessellatingPathR...
File src/gpu/GrTessellatingPathRenderer.cpp (right):

https://codereview.chromium.org/1127183006/diff/1/src/gpu/GrTessellatingPathR...
src/gpu/GrTessellatingPathRenderer.cpp:1529: SkMatrix viewMatrix =
GrTest::TestMatrixInvertible(random);
Limit to concave paths ?

https://codereview.chromium.org/1127183006/diff/1/src/gpu/GrTestUtils.cpp
File src/gpu/GrTestUtils.cpp (right):

https://codereview.chromium.org/1127183006/diff/1/src/gpu/GrTestUtils.cpp#new...
src/gpu/GrTestUtils.cpp:86: SkMatrix TestMatrixInvertible(SkRandom* random) {
Isn't this pretty much guaranteed to kill RVO?

[joshualitt, 2015-05-07 18:05:15]

feedback inc

[robertphillips, 2015-05-07 19:10:45]

lgtm + nits

https://codereview.chromium.org/1127183006/diff/20001/src/gpu/GrTestUtils.cpp
File src/gpu/GrTestUtils.cpp (right):

https://codereview.chromium.org/1127183006/diff/20001/src/gpu/GrTestUtils.cpp...
src/gpu/GrTestUtils.cpp:15: static const SkMatrix& test_matrix(SkRandom* random,
bool includePerspective) {
Shouldn't this still be 5 ?

https://codereview.chromium.org/1127183006/diff/20001/src/gpu/GrTestUtils.cpp...
src/gpu/GrTestUtils.cpp:42: namespace GrTest {
one line ?

[joshualitt, 2015-05-07 19:19:34]

On 2015/05/07 19:10:45, robertphillips wrote:
> lgtm + nits
> 
> https://codereview.chromium.org/1127183006/diff/20001/src/gpu/GrTestUtils.cpp
> File src/gpu/GrTestUtils.cpp (right):
> 
>
https://codereview.chromium.org/1127183006/diff/20001/src/gpu/GrTestUtils.cpp...
> src/gpu/GrTestUtils.cpp:15: static const SkMatrix& test_matrix(SkRandom*
random,
> bool includePerspective) {
> Shouldn't this still be 5 ?
> 
>
https://codereview.chromium.org/1127183006/diff/20001/src/gpu/GrTestUtils.cpp...
> src/gpu/GrTestUtils.cpp:42: namespace GrTest {
> one line ?

Brian, rubber stamp please.

[bsalomon, 2015-05-07 19:45:44]

On 2015/05/07 19:19:34, joshualitt wrote:
> On 2015/05/07 19:10:45, robertphillips wrote:
> > lgtm + nits
> > 
> >
https://codereview.chromium.org/1127183006/diff/20001/src/gpu/GrTestUtils.cpp
> > File src/gpu/GrTestUtils.cpp (right):
> > 
> >
>
https://codereview.chromium.org/1127183006/diff/20001/src/gpu/GrTestUtils.cpp...
> > src/gpu/GrTestUtils.cpp:15: static const SkMatrix& test_matrix(SkRandom*
> random,
> > bool includePerspective) {
> > Shouldn't this still be 5 ?
> > 
> >
>
https://codereview.chromium.org/1127183006/diff/20001/src/gpu/GrTestUtils.cpp...
> > src/gpu/GrTestUtils.cpp:42: namespace GrTest {
> > one line ?
> 
> Brian, rubber stamp please.

lgtm

[joshualitt, 2015-05-07 19:51:31]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-05-07 19:51:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1127183006/#ps40001
(title: "feedback inc")

[commit-bot: I haz the power, 2015-05-07 19:51:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1127183006/40001

[commit-bot: I haz the power, 2015-05-07 19:54:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-07 19:54:38]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[joshualitt, 2015-05-07 20:00:20]

The CQ bit was checked by joshualitt@google.com

[joshualitt, 2015-05-07 20:00:21]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1127183006/#ps2 (title:
"clang")

[commit-bot: I haz the power, 2015-05-07 20:00:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1127183006/2

[commit-bot: I haz the power, 2015-05-07 20:06:48]

Committed patchset #4 (id:2) as
https://skia.googlesource.com/skia/+/2fbd4068bde6a9fb50341c0bdfbb8bf18b70d015