Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 1127133008: NetLog: Use TimeTicks::UnixEpoch() to calculate timeTickOffset. (Closed)

Created:
5 years, 7 months ago by mmenke
Modified:
5 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NetLog: Use TimeTicks::UnixEpoch() to calculate timeTickOffset. This addresses a TODO and removes an ugly constant from NetLog. On the down side, TimeTicks::UnixEpoch() is cached, which may result in less accuracy (And all bets are off if Chrome is suspended to disk). BUG=488660 Committed: https://crrev.com/4971527414277e94682e664bf94df2274c94d17e Cr-Commit-Position: refs/heads/master@{#330376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M net/log/net_log_util.cc View 1 chunk +4 lines, -16 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
mmenke
5 years, 7 months ago (2015-05-15 23:29:04 UTC) #2
eroman
LGTM. But the suspend case sounds like a worse behavior, can you elaborate on that?
5 years, 7 months ago (2015-05-15 23:37:32 UTC) #3
mmenke
On 2015/05/15 23:37:32, eroman (sick slow) wrote: > LGTM. But the suspend case sounds like ...
5 years, 7 months ago (2015-05-15 23:49:22 UTC) #4
mmenke
Ahh....Looks like Windows, at least, handles it: QueryPerformanceCounter reads the performance counter and returns the ...
5 years, 7 months ago (2015-05-15 23:59:55 UTC) #5
mmenke
On 2015/05/15 23:59:55, mmenke wrote: > Ahh....Looks like Windows, at least, handles it: > > ...
5 years, 7 months ago (2015-05-16 00:02:04 UTC) #6
eroman
lgtm
5 years, 7 months ago (2015-05-17 22:46:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127133008/1
5 years, 7 months ago (2015-05-18 14:50:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 16:47:38 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:40:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4971527414277e94682e664bf94df2274c94d17e
Cr-Commit-Position: refs/heads/master@{#330376}

Powered by Google App Engine
This is Rietveld 408576698