Issue 112713003: drive: Split entry removal code from ChangeListProcessor::ApplyEntry

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 112713003: drive: Split entry removal code from ChangeListProcessor::ApplyEntry (Closed)

Created:
7 years ago by hashimoto

Modified:
7 years ago

Reviewers:
kinaba

CC:
chromium-reviews, tfarina, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Split entry removal code from ChangeListProcessor::ApplyEntry BUG=None TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241105

Patch Set 1 #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -53 lines)			Patch
	M	chrome/browser/chromeos/drive/change_list_processor.cc	View		2 chunks	+43 lines, -53 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/112713003/1

7 years ago (2013-12-16 08:51:29 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=204590

7 years ago (2013-12-16 09:23:40 UTC) #4

hashimoto

7 years ago (2013-12-17 02:09:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r241105 (presubmit successful).

Expand Messages | Collapse Messages