Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1127123007: Add third_party/apple_apsl from https://crrev.com/328418 (Closed)

Created:
5 years, 7 months ago by jamesr
Modified:
5 years, 7 months ago
Reviewers:
cdotstout
CC:
mojo-reviews_chromium.org, eseidel
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add third_party/apple_apsl from https://crrev.com/328418 This is needed by //base in order to build on a Mac host and will be useful for doing Mac->Android or Mac->iOS cross-compilation. R=cstout@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/a109633fe4e32c8bb51c729df5e8bc88a1e98c92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+765 lines, -0 lines) Patch
A third_party/apple_apsl/CFBase.h View 1 chunk +82 lines, -0 lines 0 comments Download
A third_party/apple_apsl/CFRuntime.h View 1 chunk +44 lines, -0 lines 0 comments Download
A third_party/apple_apsl/LICENSE View 1 chunk +327 lines, -0 lines 0 comments Download
A third_party/apple_apsl/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/apple_apsl/README.chromium View 1 chunk +61 lines, -0 lines 0 comments Download
A third_party/apple_apsl/cssmapplePriv.h View 1 chunk +77 lines, -0 lines 0 comments Download
A third_party/apple_apsl/dnsinfo.h View 1 chunk +114 lines, -0 lines 0 comments Download
A third_party/apple_apsl/malloc.h View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
jamesr
5 years, 7 months ago (2015-05-06 18:14:59 UTC) #2
cdotstout
lgtm
5 years, 7 months ago (2015-05-06 18:24:07 UTC) #3
cdotstout
lgtm
5 years, 7 months ago (2015-05-06 18:24:08 UTC) #4
jamesr
5 years, 7 months ago (2015-05-06 18:28:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a109633fe4e32c8bb51c729df5e8bc88a1e98c92 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698