Issue 1127113002: Add another test for accessing IdentityMap with SMI keys when it is _not_ empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Created:
5 years, 7 months ago by titzer

Modified:
5 years, 7 months ago

Reviewers:
Erik Corry, Erik Corry Chromium.org

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Add another test for accessing IdentityMap with SMI keys when it is _not_ empty. R=erikcorry@chromium.org BUG=

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	test/cctest/test-identity-map.cc	View		1 chunk	+12 lines, -0 lines	0 comments	Download

Total messages: 3 (1 generated)

Erik Corry

5 years, 7 months ago (2015-05-07 08:37:07 UTC) #3

Shouldn't you also fix the assert so it is before checking for emptiness?