Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(936)

Issue 1127103006: nacl_io: Add glibc IRT redirect for rename syscall (Closed)

Created:
5 years, 7 months ago by Sam Clegg
Modified:
5 years, 7 months ago
Reviewers:
binji
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

nacl_io: Add glibc IRT redirect for rename syscall This means we can remove the direct intercept, which is currently causing lua5.2 tests to fail on the naclports tree. CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk Committed: https://crrev.com/122d247af7841b388e22b22f0605a1c5b6ca490f Cr-Commit-Position: refs/heads/master@{#330279}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -11 lines) Patch
M native_client_sdk/src/libraries/nacl_io/kernel_wrap_glibc.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M native_client_sdk/src/libraries/nacl_io/library.dsc View 1 chunk +0 lines, -1 line 0 comments Download
D native_client_sdk/src/libraries/nacl_io/syscalls/rename.c View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Sam Clegg
5 years, 7 months ago (2015-05-15 21:43:33 UTC) #2
binji
lgtm
5 years, 7 months ago (2015-05-15 22:31:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127103006/20001
5 years, 7 months ago (2015-05-15 22:40:11 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_nacl_sdk on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) win_nacl_sdk on ...
5 years, 7 months ago (2015-05-15 23:44:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127103006/20001
5 years, 7 months ago (2015-05-16 00:26:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-16 04:17:25 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:31:31 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/122d247af7841b388e22b22f0605a1c5b6ca490f
Cr-Commit-Position: refs/heads/master@{#330279}

Powered by Google App Engine
This is Rietveld 408576698