Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 11271026: Fix dump_dependency_json. (Closed)

Created:
5 years ago by Torne
Modified:
5 years ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fix dump_dependency_json. dump_dependency_json needs to define CONFIGURATION_NAME like the other generators, otherwise it fails when run on real projects. Committed: https://code.google.com/p/gyp/source/detail?r=1524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M pylib/gyp/generator/dump_dependency_json.py View 1 chunk +2 lines, -1 line 0 comments Download
Trybot results:

Messages

Total messages: 2 (0 generated)
Torne
Found this while trying to track down a dependency problem :)
5 years ago (2012-10-25 15:51:02 UTC) #1
Nico
5 years ago (2012-10-25 19:33:44 UTC) #2
lgtm

This used to not be necessary before the android and ios ports landed (just fyi,
not complaining).

Powered by Google App Engine
This is Rietveld efc10ee0f