Chromium Code Reviews
Help | Chromium Project | Sign in
(75)

Issue 11271026: Fix dump_dependency_json. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Torne
Modified:
1 year, 5 months ago
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Fix dump_dependency_json.

dump_dependency_json needs to define CONFIGURATION_NAME like the other
generators, otherwise it fails when run on real projects.
Committed: https://code.google.com/p/gyp/source/detail?r=1524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Lint Patch
M pylib/gyp/generator/dump_dependency_json.py View 1 chunk +2 lines, -1 line 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 2
Torne
Found this while trying to track down a dependency problem :)
1 year, 5 months ago #1
Nico (ooo Apr 18 - Apr 20)
1 year, 5 months ago #2
lgtm

This used to not be necessary before the android and ios ports landed (just fyi,
not complaining).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6