Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Side by Side Diff: src/objects.cc

Issue 11271020: Get rid of obsolete unchecked accessors. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/json-parser.h ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 8087 matching lines...) Expand 10 before | Expand all | Expand 10 after
8098 // Make the map remember to restore the link if it survives the GC. 8098 // Make the map remember to restore the link if it survives the GC.
8099 map->set_bit_field2( 8099 map->set_bit_field2(
8100 map->bit_field2() | (1 << Map::kAttachedToSharedFunctionInfo)); 8100 map->bit_field2() | (1 << Map::kAttachedToSharedFunctionInfo));
8101 8101
8102 // Undo state changes made by StartInobjectTracking (except the 8102 // Undo state changes made by StartInobjectTracking (except the
8103 // construction_count). This way if the initial map does not survive the GC 8103 // construction_count). This way if the initial map does not survive the GC
8104 // then StartInobjectTracking will be called again the next time the 8104 // then StartInobjectTracking will be called again the next time the
8105 // constructor is called. The countdown will continue and (possibly after 8105 // constructor is called. The countdown will continue and (possibly after
8106 // several more GCs) CompleteInobjectSlackTracking will eventually be called. 8106 // several more GCs) CompleteInobjectSlackTracking will eventually be called.
8107 Heap* heap = map->GetHeap(); 8107 Heap* heap = map->GetHeap();
8108 set_initial_map(heap->raw_unchecked_undefined_value()); 8108 set_initial_map(heap->undefined_value());
8109 Builtins* builtins = heap->isolate()->builtins(); 8109 Builtins* builtins = heap->isolate()->builtins();
8110 ASSERT_EQ(builtins->builtin(Builtins::kJSConstructStubCountdown), 8110 ASSERT_EQ(builtins->builtin(Builtins::kJSConstructStubCountdown),
8111 *RawField(this, kConstructStubOffset)); 8111 *RawField(this, kConstructStubOffset));
8112 set_construct_stub(builtins->builtin(Builtins::kJSConstructStubGeneric)); 8112 set_construct_stub(builtins->builtin(Builtins::kJSConstructStubGeneric));
8113 // It is safe to clear the flag: it will be set again if the map is live. 8113 // It is safe to clear the flag: it will be set again if the map is live.
8114 set_live_objects_may_exist(false); 8114 set_live_objects_may_exist(false);
8115 } 8115 }
8116 8116
8117 8117
8118 // Called from GC, hence reinterpret_cast and unchecked accessors. 8118 // Called from GC, hence reinterpret_cast and unchecked accessors.
(...skipping 5354 matching lines...) Expand 10 before | Expand all | Expand 10 after
13473 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER); 13473 set_year(Smi::FromInt(year), SKIP_WRITE_BARRIER);
13474 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER); 13474 set_month(Smi::FromInt(month), SKIP_WRITE_BARRIER);
13475 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER); 13475 set_day(Smi::FromInt(day), SKIP_WRITE_BARRIER);
13476 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER); 13476 set_weekday(Smi::FromInt(weekday), SKIP_WRITE_BARRIER);
13477 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER); 13477 set_hour(Smi::FromInt(hour), SKIP_WRITE_BARRIER);
13478 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER); 13478 set_min(Smi::FromInt(min), SKIP_WRITE_BARRIER);
13479 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER); 13479 set_sec(Smi::FromInt(sec), SKIP_WRITE_BARRIER);
13480 } 13480 }
13481 13481
13482 } } // namespace v8::internal 13482 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/json-parser.h ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698