Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: regexp2000/test/cctest/test-regexp.cc

Issue 11271: Building on regexp-ia32. (Closed)
Patch Set: Made it compile correctly. Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: regexp2000/test/cctest/test-regexp.cc
diff --git a/regexp2000/test/cctest/test-regexp.cc b/regexp2000/test/cctest/test-regexp.cc
index 6f95852d91cc515ce6dc69d90494e8f6a37531e6..566ae4f06aca7101649e54335a37b7ec247e8e52 100644
--- a/regexp2000/test/cctest/test-regexp.cc
+++ b/regexp2000/test/cctest/test-regexp.cc
@@ -274,7 +274,7 @@ TEST(Errors) {
ExpectError("[a-\\w]", kIllegalCharacterClass);
const char* kEndControl = "\\c at end of pattern";
ExpectError("\\c", kEndControl);
- static char* kNothingToRepeat = "Nothing to repeat";
+ const char* kNothingToRepeat = "Nothing to repeat";
Erik Corry 2008/11/21 13:03:04 Surely 'static const'?
Lasse Reichstein 2008/11/24 08:32:33 Why? None of the other char*'s are static. Would
ExpectError("*", kNothingToRepeat);
ExpectError("?", kNothingToRepeat);
ExpectError("+", kNothingToRepeat);

Powered by Google App Engine
This is Rietveld 408576698