Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2006-2008 the V8 project authors. All rights reserved. | 1 // Copyright 2006-2008 the V8 project authors. All rights reserved. |
| 2 // Redistribution and use in source and binary forms, with or without | 2 // Redistribution and use in source and binary forms, with or without |
| 3 // modification, are permitted provided that the following conditions are | 3 // modification, are permitted provided that the following conditions are |
| 4 // met: | 4 // met: |
| 5 // | 5 // |
| 6 // * Redistributions of source code must retain the above copyright | 6 // * Redistributions of source code must retain the above copyright |
| 7 // notice, this list of conditions and the following disclaimer. | 7 // notice, this list of conditions and the following disclaimer. |
| 8 // * Redistributions in binary form must reproduce the above | 8 // * Redistributions in binary form must reproduce the above |
| 9 // copyright notice, this list of conditions and the following | 9 // copyright notice, this list of conditions and the following |
| 10 // disclaimer in the documentation and/or other materials provided | 10 // disclaimer in the documentation and/or other materials provided |
| (...skipping 256 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 267 ExpectError("(foo", kUnterminatedGroup); | 267 ExpectError("(foo", kUnterminatedGroup); |
| 268 const char* kInvalidGroup = "Invalid group"; | 268 const char* kInvalidGroup = "Invalid group"; |
| 269 ExpectError("(?", kInvalidGroup); | 269 ExpectError("(?", kInvalidGroup); |
| 270 const char* kUnterminatedCharacterClass = "Unterminated character class"; | 270 const char* kUnterminatedCharacterClass = "Unterminated character class"; |
| 271 ExpectError("[", kUnterminatedCharacterClass); | 271 ExpectError("[", kUnterminatedCharacterClass); |
| 272 ExpectError("[a-", kUnterminatedCharacterClass); | 272 ExpectError("[a-", kUnterminatedCharacterClass); |
| 273 const char* kIllegalCharacterClass = "Illegal character class"; | 273 const char* kIllegalCharacterClass = "Illegal character class"; |
| 274 ExpectError("[a-\\w]", kIllegalCharacterClass); | 274 ExpectError("[a-\\w]", kIllegalCharacterClass); |
| 275 const char* kEndControl = "\\c at end of pattern"; | 275 const char* kEndControl = "\\c at end of pattern"; |
| 276 ExpectError("\\c", kEndControl); | 276 ExpectError("\\c", kEndControl); |
| 277 static char* kNothingToRepeat = "Nothing to repeat"; | 277 const char* kNothingToRepeat = "Nothing to repeat"; |
|
Erik Corry
2008/11/21 13:03:04
Surely 'static const'?
Lasse Reichstein
2008/11/24 08:32:33
Why?
None of the other char*'s are static.
Would
| |
| 278 ExpectError("*", kNothingToRepeat); | 278 ExpectError("*", kNothingToRepeat); |
| 279 ExpectError("?", kNothingToRepeat); | 279 ExpectError("?", kNothingToRepeat); |
| 280 ExpectError("+", kNothingToRepeat); | 280 ExpectError("+", kNothingToRepeat); |
| 281 ExpectError("{1}", kNothingToRepeat); | 281 ExpectError("{1}", kNothingToRepeat); |
| 282 ExpectError("{1,2}", kNothingToRepeat); | 282 ExpectError("{1,2}", kNothingToRepeat); |
| 283 ExpectError("{1,}", kNothingToRepeat); | 283 ExpectError("{1,}", kNothingToRepeat); |
| 284 } | 284 } |
| 285 | 285 |
| 286 | 286 |
| 287 static bool IsDigit(uc16 c) { | 287 static bool IsDigit(uc16 c) { |
| (...skipping 521 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 809 ZoneScope zone_scope(DELETE_ON_EXIT); | 809 ZoneScope zone_scope(DELETE_ON_EXIT); |
| 810 RegExpNode* node = Compile("(a|^b|c)"); | 810 RegExpNode* node = Compile("(a|^b|c)"); |
| 811 CHECK(node->info()->determine_start); | 811 CHECK(node->info()->determine_start); |
| 812 } | 812 } |
| 813 | 813 |
| 814 | 814 |
| 815 TEST(Graph) { | 815 TEST(Graph) { |
| 816 V8::Initialize(NULL); | 816 V8::Initialize(NULL); |
| 817 Execute(".*o(?=o)", "", true); | 817 Execute(".*o(?=o)", "", true); |
| 818 } | 818 } |
| OLD | NEW |