Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1127073003: [iOS] Upstream FirstRun configuration and metrics (Closed)

Created:
5 years, 7 months ago by sdefresne
Modified:
5 years, 7 months ago
Reviewers:
jif
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream FirstRun configuration and metrics BUG=429756 R=jif@chromium.org Committed: https://crrev.com/0be1074956cd426ce8a9c5a756ab82d4637f3688 Cr-Commit-Position: refs/heads/master@{#329162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -5 lines) Patch
A + ios/chrome/browser/first_run/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/first_run/first_run.mm View 3 chunks +2 lines, -4 lines 0 comments Download
A ios/chrome/browser/first_run/first_run_configuration.h View 1 chunk +20 lines, -0 lines 0 comments Download
A ios/chrome/browser/first_run/first_run_configuration.mm View 1 chunk +14 lines, -0 lines 0 comments Download
A ios/chrome/browser/first_run/first_run_metrics.h View 1 chunk +59 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
sdefresne
5 years, 7 months ago (2015-05-11 15:35:17 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127073003/1
5 years, 7 months ago (2015-05-11 15:35:20 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-11 15:50:32 UTC) #5
jif
lgtm
5 years, 7 months ago (2015-05-11 16:44:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127073003/1
5 years, 7 months ago (2015-05-11 16:46:37 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 16:58:05 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 16:59:03 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0be1074956cd426ce8a9c5a756ab82d4637f3688
Cr-Commit-Position: refs/heads/master@{#329162}

Powered by Google App Engine
This is Rietveld 408576698