Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1127043006: GYP dependencies for JNI _java targets moved to device targets that require them. (Closed)

Created:
5 years, 7 months ago by scheib
Modified:
5 years, 7 months ago
Reviewers:
nyquist, armansito, jam, cjhopman
CC:
chromium-reviews, darin-cc_chromium.org, scheib+watch_chromium.org, jam, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GYP dependencies for JNI _java targets moved to device targets that require them. Previously _java targets for android JNI were indirectly included in build dependencies by higher level targets. This change moves the dependencies directly to the targets that require them. Committed: https://crrev.com/f1242e526088837d9cac99bce9fbf1e9de47423f Cr-Commit-Position: refs/heads/master@{#331068}

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M content/content.gyp View 1 chunk +0 lines, -2 lines 1 comment Download
M device/battery/battery.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M device/device_tests.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M device/vibration/vibration.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 22 (8 generated)
scheib
5 years, 7 months ago (2015-05-13 22:49:03 UTC) #3
scheib
https://codereview.chromium.org/1127043006/diff/20001/content/content.gyp File content/content.gyp (right): https://codereview.chromium.org/1127043006/diff/20001/content/content.gyp#newcode431 content/content.gyp:431: '../device/battery/battery.gyp:device_battery_java', Note, content actually has java dependencies on device_battery_java ...
5 years, 7 months ago (2015-05-13 22:50:08 UTC) #4
nyquist
I was under the impression that currently, the _java targets are usually not depended on ...
5 years, 7 months ago (2015-05-14 00:33:19 UTC) #6
cjhopman
lgtm
5 years, 7 months ago (2015-05-20 02:34:12 UTC) #7
nyquist
given our recent discussion, lgtm
5 years, 7 months ago (2015-05-20 05:59:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127043006/20001
5 years, 7 months ago (2015-05-20 15:25:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64916)
5 years, 7 months ago (2015-05-20 15:31:26 UTC) #12
scheib
armansito, PTAL device/*
5 years, 7 months ago (2015-05-20 15:34:19 UTC) #14
armansito
lgtm
5 years, 7 months ago (2015-05-21 02:31:24 UTC) #15
scheib
jam@chromium.org: content/content.gyp
5 years, 7 months ago (2015-05-21 16:16:04 UTC) #17
jam
lgtm
5 years, 7 months ago (2015-05-22 04:18:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1127043006/20001
5 years, 7 months ago (2015-05-22 04:36:29 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-22 05:31:16 UTC) #21
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 05:32:17 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f1242e526088837d9cac99bce9fbf1e9de47423f
Cr-Commit-Position: refs/heads/master@{#331068}

Powered by Google App Engine
This is Rietveld 408576698