Issue 1127043004: Fix fx_string.h compile error under chromium checkouts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1127043004: Fix fx_string.h compile error under chromium checkouts (Closed)

Created:
5 years, 7 months ago by Tom Sepez

Modified:
5 years, 7 months ago

Reviewers:

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix fx_string.h compile error under chromium checkouts. This gets included in chromium's pdfium_engine.cc, and thus must pass a higher error level. There's probably a follow-up to check why the FPDF_ api doesn't insulate chromium from this file. TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/ad2a822ce5c320c61510ffdc309f766ab1056ef5

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	core/include/fxcrt/fx_string.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Tom Sepez

Committed patchset #1 (id:1) manually as ad2a822ce5c320c61510ffdc309f766ab1056ef5 (presubmit successful).

5 years, 7 months ago (2015-05-06 19:40:28 UTC) #1

Message was sent while issue was closed.

TBR'd.