Beginnings of synchronizing notifications in the notification database.

chrome/browser/notifications/platform_notification_service_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/platform_notification_service_impl.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/notifications/desktop_notification_profile_util.h"
@@ skipping 288 matching lines @@
   if (iter == persistent_notifications_.end())
     return;
 
   GetNotificationUIManager()->CancelById(
       iter->second, NotificationUIManager::GetProfileID(profile));
 
   persistent_notifications_.erase(iter);
 #endif
 }
 
+bool PlatformNotificationServiceImpl::GetDisplayedPersistentNotifications(
+    BrowserContext* browser_context,
+    std::set<std::string>* displayed_notifications) {
+  DCHECK(displayed_notifications);
+
+#if !defined(OS_ANDROID)
+  Profile* profile = Profile::FromBrowserContext(browser_context);
+
+  // TODO(peter): Filter for persistent notifications only.

[johnme, 2015/05/14 15:22:32]

How hard would it be to implement this TODO now? IIRC non-persistent
notifications have GUIDs (with dashes), so anything that base::StringToInt64
succeeds on should be persistent? This would tie in nicely with
displayed_notifications being a std::set<int64_t>*

[Peter Beverloo, 2015/05/14 16:03:34]

No, that's not the case, the delegate ids for persistent notifications still are
GUIDs. (See notification_object_proxy.cc.) This is two steps in the future - we
need //content to generate the notification Ids (which is in review separately)
and then to identify persistent notifications so that we can fulfill the TODOs
in PlatformNotificationContextImpl as well.

+  *displayed_notifications =
+      GetNotificationUIManager()->GetAllIdsByProfile(profile);
+
+  return true;
+#else
+  // Android cannot reliably return the notifications that are currently being
+  // displayed on the platform, see the comment in NotificationUIManagerAndroid.
+  return false;
+#endif

[johnme, 2015/05/14 15:22:32]

Micro-nit: #endif  // !defined(OS_ANDROID)

[Peter Beverloo, 2015/05/14 16:03:34]

Done.

+}
+
 Notification PlatformNotificationServiceImpl::CreateNotificationFromData(
     Profile* profile,
     const GURL& origin,
     const SkBitmap& icon,
     const content::PlatformNotificationData& notification_data,
     NotificationDelegate* delegate) const {
   base::string16 display_source = DisplayNameForOrigin(profile, origin);
 
   // TODO(peter): Icons for Web Notifications are currently always requested for
   // 1x scale, whereas the displays on which they can be displayed can have a
@@ skipping 66 matching lines @@
       formatted_origin.push_back(':');
       formatted_origin.append(base::UTF8ToUTF16(origin.port()));
     }
     return formatted_origin;
   }
 
   // TODO(dewittj): Once file:// URLs are passed in to the origin
   // GURL here, begin returning the path as the display name.
   return net::FormatUrl(origin, languages);
 }