Beginnings of synchronizing notifications in the notification database.

chrome/browser/notifications/message_center_notification_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/message_center_notification_manager.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
@@ skipping 219 matching lines @@
 }
 
 std::set<std::string>
 MessageCenterNotificationManager::GetAllIdsByProfileAndSourceOrigin(
     Profile* profile,
     const GURL& source) {
   // The profile pointer can be weak, the instance may have been destroyed, so
   // no profile method should be called inside this function.
 
   std::set<std::string> delegate_ids;
-  for (NotificationMap::iterator iter = profile_notifications_.begin();
-       iter != profile_notifications_.end(); iter++) {
-    if ((*iter).second->notification().origin_url() == source &&
-        profile == (*iter).second->profile()) {
-      delegate_ids.insert(iter->second->notification().delegate_id());
+  for (const auto& iter : profile_notifications_) {

[johnme, 2015/05/14 15:22:32]

s/iter/entry/ or 'pair' or something, ditto below.

[Peter Beverloo, 2015/05/14 16:03:34]

Done.

+    const Notification& notification = iter.second->notification();
+    if (iter.second->profile() == profile &&
+        notification.origin_url() == source) {
+      delegate_ids.insert(notification.delegate_id());
     }
   }
+
   return delegate_ids;
 }
 
+std::set<std::string> MessageCenterNotificationManager::GetAllIdsByProfile(
+    Profile* profile) {
+  // The profile pointer can be weak, the instance may have been destroyed, so

[johnme, 2015/05/14 15:22:32]

Eww gross. Since this is a new method, can we just DCHECK(profile)?

[Peter Beverloo, 2015/05/14 16:03:34]

As discussed offline, this is a common pattern in the API :(. Added a TODO to
update this and GAIBPASO() to use ProfileID.

+  // no profile method should be called inside this function.
+
+  std::set<std::string> delegate_ids;
+  for (const auto& iter : profile_notifications_) {
+    if (iter.second->profile() == profile)
+      delegate_ids.insert(iter.second->notification().delegate_id());
+  }
+
+  return delegate_ids;
+}
+
 bool MessageCenterNotificationManager::CancelAllBySourceOrigin(
     const GURL& source) {
   // Same pattern as CancelById, but more complicated than the above
   // because there may be multiple notifications from the same source.
   bool removed = false;
 
   for (NotificationMap::iterator loopiter = profile_notifications_.begin();
        loopiter != profile_notifications_.end(); ) {
     NotificationMap::iterator curiter = loopiter++;
     if ((*curiter).second->notification().origin_url() == source) {
@@ skipping 146 matching lines @@
        it != registry->enabled_extensions().end();
        ++it) {
     if ((*it->get()).permissions_data()->HasAPIPermission(
             extensions::APIPermission::ID::kNotificationProvider)) {
       extension_id = (*it->get()).id();
       return extension_id;
     }
   }
   return extension_id;
 }