Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Unified Diff: content/renderer/render_widget.cc

Issue 11270042: Add non-member non-mutating methods for common gfx::Rect operations. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 9c3872e6d138a3b56029870ce0644613ff0ff532..c90e80c5d3a0bd3c647aea8caf2ad826919db39c 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -373,13 +373,11 @@ void RenderWidget::OnChangeResizeRect(const gfx::Rect& resizer_rect) {
if (resizer_rect_ != resizer_rect) {
gfx::Rect view_rect(size_);
- gfx::Rect old_damage_rect = view_rect;
- old_damage_rect.Intersect(resizer_rect_);
+ gfx::Rect old_damage_rect = gfx::Intersection(view_rect, resizer_rect_);
if (!old_damage_rect.IsEmpty())
paint_aggregator_.InvalidateRect(old_damage_rect);
- gfx::Rect new_damage_rect = view_rect;
- new_damage_rect.Intersect(resizer_rect);
+ gfx::Rect new_damage_rect = gfx::Intersection(view_rect, resizer_rect);
if (!new_damage_rect.IsEmpty())
paint_aggregator_.InvalidateRect(new_damage_rect);
@@ -937,8 +935,7 @@ void RenderWidget::DoDeferredUpdate() {
paint_aggregator_.PopPendingUpdate(&update);
gfx::Rect scroll_damage = update.GetScrollDamage();
- gfx::Rect bounds = update.GetPaintBounds();
- bounds.Union(scroll_damage);
+ gfx::Rect bounds = gfx::Union(update.GetPaintBounds(), scroll_damage);
// Notify derived classes that we're about to initiate a paint.
WillInitiatePaint();
@@ -984,9 +981,8 @@ void RenderWidget::DoDeferredUpdate() {
pending_update_params_->scale_factor = dib_scale_factor;
} else if (!is_accelerated_compositing_active_) {
// Compute a buffer for painting and cache it.
- gfx::RectF scaled_bounds = bounds;
- scaled_bounds.Scale(device_scale_factor_);
- gfx::Rect pixel_bounds = gfx::ToEnclosingRect(scaled_bounds);
+ gfx::Rect pixel_bounds = gfx::ToEnclosingRect(
+ gfx::Scale(bounds, device_scale_factor_));
scoped_ptr<skia::PlatformCanvas> canvas(
RenderProcess::current()->GetDrawingCanvas(&current_paint_buf_,
pixel_bounds));
@@ -1064,8 +1060,7 @@ void RenderWidget::DoDeferredUpdate() {
void RenderWidget::didInvalidateRect(const WebRect& rect) {
// The invalidated rect might be outside the bounds of the view.
gfx::Rect view_rect(size_);
- gfx::Rect damaged_rect = view_rect;
- damaged_rect.Intersect(rect);
+ gfx::Rect damaged_rect = gfx::Intersection(view_rect, rect);
if (damaged_rect.IsEmpty())
return;
@@ -1105,8 +1100,7 @@ void RenderWidget::didScrollRect(int dx, int dy, const WebRect& clip_rect) {
// The scrolled rect might be outside the bounds of the view.
gfx::Rect view_rect(size_);
- gfx::Rect damaged_rect = view_rect;
- damaged_rect.Intersect(clip_rect);
+ gfx::Rect damaged_rect = gfx::Intersection(view_rect, clip_rect);
if (damaged_rect.IsEmpty())
return;

Powered by Google App Engine
This is Rietveld 408576698