[autofill] Adding new API to request an interactive autocomplete UI flow.

chrome/renderer/autofill/autofill_agent.h

Index: chrome/renderer/autofill/autofill_agent.h
diff --git a/chrome/renderer/autofill/autofill_agent.h b/chrome/renderer/autofill/autofill_agent.h
index 89f0a31c0084810a26752b1b56d7a7851c3d3f3a..a7d7d5970c0bff69306a78550f09974b9c80fe25 100644
--- a/chrome/renderer/autofill/autofill_agent.h
+++ b/chrome/renderer/autofill/autofill_agent.h
@@ -88,6 +88,9 @@ class AutofillAgent : public content::RenderViewObserver,
   virtual void textFieldDidReceiveKeyDown(
       const WebKit::WebInputElement& element,
       const WebKit::WebKeyboardEvent& event) OVERRIDE;
+  virtual void didRequestAutocomplete(
+      WebKit::WebFrame* frame,
+      const WebKit::WebFormElement& form) OVERRIDE;
 
   void OnSuggestionsReturned(int query_id,
                              const std::vector<string16>& values,
@@ -108,6 +111,9 @@ class AutofillAgent : public content::RenderViewObserver,
   void OnAcceptDataListSuggestion(const string16& value);
   void OnAcceptPasswordAutofillSuggestion(const string16& value);
 
+  // For interactive autocomplete.
+  void OnRequestAutocompleteFinished(int query_id, int result);
+
   // Called in a posted task by textFieldDidChange() to work-around a WebKit bug
   // http://bugs.webkit.org/show_bug.cgi?id=16976
   void TextFieldDidChangeImpl(const WebKit::WebInputElement& element);
@@ -163,6 +169,9 @@ class AutofillAgent : public content::RenderViewObserver,
   // Set |node| to display the given |value|.
   void SetNodeText(const string16& value, WebKit::WebInputElement* node);
 
+  // Hides any currently showing autofill popups.

[Ilya Sherman, 2012/10/27 07:44:11]

nit: "autofill" -> "Autofill"

[Dan Beam, 2012/10/29 19:17:05]

Done.

+  void HidePopups();
+
   FormCache form_cache_;
 
   PasswordAutofillManager* password_autofill_manager_;  // WEAK reference.
@@ -174,6 +183,10 @@ class AutofillAgent : public content::RenderViewObserver,
   // The element corresponding to the last request sent for form field Autofill.
   WebKit::WebInputElement element_;
 
+  // The element corresponding to the last request sent for an interactive
+  // autocomplete.
+  WebKit::WebFormElement form_;

[Ilya Sherman, 2012/10/27 07:44:11]

It doesn't seem like this will work if multiple tabs in a single renderer can
have separate dialogs open simultaneously.

[Evan Stade, 2012/10/29 17:54:28]

there's only one AutofillAgent per RenderView. RenderView 1:1 tab. Render view
many:1 renderer process.

[Ilya Sherman, 2012/10/29 17:59:23]

Ok, that makes this much easier to reason about -- thanks for clarifying that. 
Given that this is the case, I don't think we actually need a separate variable
to track the IPC message id for this set of IPCs.  Do y'all agree, or is there
still a reason to separate the two?

[Dan Beam, 2012/10/29 19:17:05]

Currently, the webkit implementation will hit the request *sending* code every
time formEl.requestAutocomplete() is called.  It seems like we could do 1 of two
things to address multiple requests -

1) keep a boolean and ignore pending requests and remove the IPC query ID, or
2) keep query ID and queue requests or ignore older requests.

I lean toward #1 unless we think it's a valid use case to show Infinity
autocomplete UIs back to back (which I think is an easy way to end up in a rick
roll alert() loop).

+
   // The action to take when receiving Autofill data from the AutofillManager.
   AutofillAction autofill_action_;