Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: runtime/vm/intermediate_language.h

Issue 11270013: Fix deoptimzation bug in hoisting smi operation out of loops. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_INTERMEDIATE_LANGUAGE_H_ 5 #ifndef VM_INTERMEDIATE_LANGUAGE_H_
6 #define VM_INTERMEDIATE_LANGUAGE_H_ 6 #define VM_INTERMEDIATE_LANGUAGE_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/ast.h" 9 #include "vm/ast.h"
10 #include "vm/growable_array.h" 10 #include "vm/growable_array.h"
(...skipping 501 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 } 512 }
513 513
514 private: 514 private:
515 friend class Definition; // Needed for InsertBefore, InsertAfter. 515 friend class Definition; // Needed for InsertBefore, InsertAfter.
516 516
517 // Classes that set deopt_id_. 517 // Classes that set deopt_id_.
518 friend class UnboxIntegerInstr; 518 friend class UnboxIntegerInstr;
519 friend class UnboxDoubleInstr; 519 friend class UnboxDoubleInstr;
520 friend class BinaryDoubleOpInstr; 520 friend class BinaryDoubleOpInstr;
521 friend class BinaryMintOpInstr; 521 friend class BinaryMintOpInstr;
522 friend class BinarySmiOpInstr;
522 friend class ShiftMintOpInstr; 523 friend class ShiftMintOpInstr;
523 friend class UnaryMintOpInstr; 524 friend class UnaryMintOpInstr;
524 friend class MathSqrtInstr; 525 friend class MathSqrtInstr;
525 friend class CheckClassInstr; 526 friend class CheckClassInstr;
526 friend class CheckSmiInstr; 527 friend class CheckSmiInstr;
527 friend class CheckArrayBoundInstr; 528 friend class CheckArrayBoundInstr;
528 friend class CheckEitherNonSmiInstr; 529 friend class CheckEitherNonSmiInstr;
529 friend class LICM; 530 friend class LICM;
530 531
531 intptr_t deopt_id_; 532 intptr_t deopt_id_;
(...skipping 3210 matching lines...) Expand 10 before | Expand all | Expand 10 after
3742 InstanceCallInstr* instance_call, 3743 InstanceCallInstr* instance_call,
3743 Value* left, 3744 Value* left,
3744 Value* right) 3745 Value* right)
3745 : op_kind_(op_kind), 3746 : op_kind_(op_kind),
3746 instance_call_(instance_call), 3747 instance_call_(instance_call),
3747 overflow_(true) { 3748 overflow_(true) {
3748 ASSERT(left != NULL); 3749 ASSERT(left != NULL);
3749 ASSERT(right != NULL); 3750 ASSERT(right != NULL);
3750 inputs_[0] = left; 3751 inputs_[0] = left;
3751 inputs_[1] = right; 3752 inputs_[1] = right;
3753 deopt_id_ = instance_call->deopt_id();
3752 } 3754 }
3753 3755
3754 Value* left() const { return inputs_[0]; } 3756 Value* left() const { return inputs_[0]; }
3755 Value* right() const { return inputs_[1]; } 3757 Value* right() const { return inputs_[1]; }
3756 3758
3757 Token::Kind op_kind() const { return op_kind_; } 3759 Token::Kind op_kind() const { return op_kind_; }
3758 3760
3759 InstanceCallInstr* instance_call() const { return instance_call_; } 3761 InstanceCallInstr* instance_call() const { return instance_call_; }
3760 3762
3761 const ICData* ic_data() const { return instance_call()->ic_data(); } 3763 const ICData* ic_data() const { return instance_call()->ic_data(); }
(...skipping 488 matching lines...) Expand 10 before | Expand all | Expand 10 after
4250 ForwardInstructionIterator* current_iterator_; 4252 ForwardInstructionIterator* current_iterator_;
4251 4253
4252 private: 4254 private:
4253 DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor); 4255 DISALLOW_COPY_AND_ASSIGN(FlowGraphVisitor);
4254 }; 4256 };
4255 4257
4256 4258
4257 } // namespace dart 4259 } // namespace dart
4258 4260
4259 #endif // VM_INTERMEDIATE_LANGUAGE_H_ 4261 #endif // VM_INTERMEDIATE_LANGUAGE_H_
OLDNEW
« no previous file with comments | « no previous file | runtime/vm/intermediate_language_ia32.cc » ('j') | runtime/vm/intermediate_language_ia32.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698