media/base/rtc_audio_renderer.cc - Issue 11270012: Adding audio support to the new webmediaplyer

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/base/rtc_audio_renderer.cc

Issue 11270012: Adding audio support to the new webmediaplyer (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added a lock to protect the |renderer_| Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4
	wjia(left Chromium) 2012/10/24 22:05:15 Is this a newly added file, or a renamed version o Is this a newly added file, or a renamed version of AudioRenderer? Somehow the history of this file is different from its header file. no longer working on chromium 2012/10/25 10:19:41 Yes, it is weird. It is a new file. I copied the a Show quoted text On 2012/10/24 22:05:15, wjia wrote: > Is this a newly added file, or a renamed version of AudioRenderer? Somehow the > history of this file is different from its header file. Yes, it is weird. It is a new file. I copied the audio_renderer.h/cc and modified them to rtc_audio_renderer.h/cc, for some reason git cl keeps the history of audio_renderer.cc. I am not sure how to remove the wrong history. Another thing here is the naming, it is unsure if rtc_audio_renderer is a good name, since I use webrtc_audio_renderer for its implementation in content/renderer/media. How do you think if I change the interface file to webrtc_audio_renderer, and use webrtc_audio_renderer_impl as the implementation file name? Or any other suggestion? wjia(left Chromium) 2012/10/25 14:15:05 From WebMediaPlayer point of view, it's audio_play Show quoted text On 2012/10/25 10:19:41, xians1 wrote: > On 2012/10/24 22:05:15, wjia wrote: > > Is this a newly added file, or a renamed version of AudioRenderer? Somehow the > > history of this file is different from its header file. > > Yes, it is weird. It is a new file. I copied the audio_renderer.h/cc and > modified them to rtc_audio_renderer.h/cc, for some reason git cl keeps the > history of audio_renderer.cc. I am not sure how to remove the wrong history. > > Another thing here is the naming, it is unsure if rtc_audio_renderer is a good > name, since I use webrtc_audio_renderer for its implementation in > content/renderer/media. How do you think if I change the interface file to > webrtc_audio_renderer, and use webrtc_audio_renderer_impl as the implementation > file name? > Or any other suggestion? From WebMediaPlayer point of view, it's audio_player, not just audio_renderer. Some people think "pause" will pause the source of media element as well. I am trying to sort out what's really desired. For now, it's ok to keep current name. We can refactor later.
5 #include "media/base/audio_renderer.h"	5 #include "media/base/rtc_audio_renderer.h"

6	6

7 namespace media {	7 namespace media {

8	8

9 AudioRenderer::AudioRenderer() {}	9 RtcAudioRenderer::RtcAudioRenderer() {}

10 AudioRenderer::~AudioRenderer() {}	10 RtcAudioRenderer::~RtcAudioRenderer() {}

11	11

12 } // namespace media	12 } // namespace media

OLD	NEW

« media/base/rtc_audio_renderer.h ('K') | « media/base/rtc_audio_renderer.h ('k') | media/media.gyp » ('j') | webkit/media/webmediaplayer_ms.cc » ('J')