Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(701)

Unified Diff: lib/compiler/implementation/ssa/builder.dart

Issue 11270008: Add type annotations to remove warnings and fix a bug. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/compiler/implementation/ssa/builder.dart
diff --git a/lib/compiler/implementation/ssa/builder.dart b/lib/compiler/implementation/ssa/builder.dart
index d48f76ee959121bff3828e1f9aab731273648cab..13e3a2be2bb0a2740dbf5a8f6c8a5916eaa05047 100644
--- a/lib/compiler/implementation/ssa/builder.dart
+++ b/lib/compiler/implementation/ssa/builder.dart
@@ -2198,7 +2198,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
// An erroneous element indicates an unresolved static getter.
generateThrowNoSuchMethod(send,
getTargetName(element, 'get'),
- const Link<Node>());
+ argumentNodes: const Link<Node>());
} else {
stack.add(localsHandler.readLocal(element));
}
@@ -2247,7 +2247,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
// An erroneous element indicates an unresolved static setter.
generateThrowNoSuchMethod(send,
getTargetName(element, 'set'),
- send.arguments);
+ argumentNodes: send.arguments);
} else {
stack.add(value);
// If the value does not already have a name, give it here.
@@ -2974,7 +2974,9 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
Selector selector = elements.getSelector(node);
Element element = elements[node];
if (element.isErroneous()) {
- generateThrowNoSuchMethod(node, getTargetName(element), node.arguments);
+ generateThrowNoSuchMethod(node,
+ getTargetName(element),
+ argumentNodes: node.arguments);
return;
}
if (identical(element, compiler.assertMethod) && !compiler.enableUserAssertions) {
@@ -3053,8 +3055,8 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
void generateThrowNoSuchMethod(Node diagnosticNode,
String methodName,
- [Link<Node> argumentNodes,
- List<HInstruction> argumentValues]) {
+ {Link<Node> argumentNodes,
+ List<HInstruction> argumentValues}) {
Element helper =
compiler.findHelper(const SourceString('throwNoSuchMethod'));
Constant receiverConstant =
@@ -3084,7 +3086,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
if (error.messageKind == MessageKind.CANNOT_FIND_CONSTRUCTOR) {
generateThrowNoSuchMethod(node.send,
getTargetName(error, 'constructor'),
- node.send.arguments);
+ argumentNodes: node.send.arguments);
} else if (error.messageKind == MessageKind.CANNOT_RESOLVE) {
Message message = error.messageKind.message(error.messageArguments);
generateRuntimeError(node.send, message.toString());
@@ -3462,7 +3464,7 @@ class SsaBuilder extends ResolvedVisitor implements Visitor {
if (variable.isErroneous()) {
generateThrowNoSuchMethod(node,
getTargetName(variable, 'set'),
- <HInstruction>[oldVariable]);
+ argumentValues: <HInstruction>[oldVariable]);
pop();
} else {
localsHandler.updateLocal(variable, oldVariable);
« no previous file with comments | « lib/compiler/implementation/scanner/parser.dart ('k') | lib/compiler/implementation/ssa/value_range_analyzer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698