Issue 11270: * Remove unexpected passes from mozilla.status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11270: * Remove unexpected passes from mozilla.status. (Closed)

Created:
12 years, 1 month ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/regexp2000/

Visibility:
Public.

Description

* Remove unexpected passes from mozilla.status. * Fix lint issue. Committed: http://code.google.com/p/v8/source/detail?r=794

Patch Set 1 #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -10 lines)			Patch
	M	src/interpreter-re2k.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	test/mozilla/mozilla.status	View		2 chunks	+0 lines, -9 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Christian Plesner Hansen

12 years, 1 month ago (2008-11-19 12:10:28 UTC) #2

Lbtm, except for the lint thing.

http://codereview.chromium.org/11270/diff/1/2
File test/mozilla/mozilla.status (left):

http://codereview.chromium.org/11270/diff/1/2#oldcode247
Line 247: 
If we're going to continue to fall back on jscre we can't just remove these.

Expand Messages | Collapse Messages