Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1126983009: Handle integer -0 as 0 in extensions (Closed)

Created:
5 years, 7 months ago by qiankun
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle integer -0 as 0 in extensions -0 is treated as double 0.0f in V8. This makes GetAsInteger() return -0 is not an integer type. Extension APIs with integer parameters will fail to get the value using GetAsInteger(). This CL convert integer -0 to integer 0. BUG=471011 Committed: https://crrev.com/8e575f12fb732a497e0e9fc34e1e739621cecf3c Cr-Commit-Position: refs/heads/master@{#329860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M extensions/renderer/resources/schema_utils.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qiankun
PTAL.
5 years, 7 months ago (2015-05-14 10:00:24 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 7 months ago (2015-05-14 14:52:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1126983009/1
5 years, 7 months ago (2015-05-14 15:19:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 16:52:00 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 16:53:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8e575f12fb732a497e0e9fc34e1e739621cecf3c
Cr-Commit-Position: refs/heads/master@{#329860}

Powered by Google App Engine
This is Rietveld 408576698