cc: Make HasImplThread() function work in AfterTest().

cc: Make HasImplThread() function work in AfterTest().

Before we run AfterTest() the layer_tree_host is destroyed (to allow AfterTest
to check that proper cleanup has occurred) which means that the proxy() object
is null. This means that HasImplThread() would previously return false in the
AfterTest() method even when running on a test which was created using
RunTest(threaded=true).

R=danakj

Committed: https://crrev.com/e88f9dd1cf36789957044409e97e63987c23307c
Cr-Commit-Position: refs/heads/master@{#328667}

[mithro-old, 2015-05-06 01:35:42]

Hi Dana,

This patch adds a test which shows the HasImplThread() failure and one possible
fix for the problem.

Alternative fixes could be;
 * Adding an AfterTestBeforeCleanup() or similar function which runs before we
destroy the layer_tree_host_.
 * Storing and using the threaded_ value rather than depending on the impl
thread existing.

Tim 'mithro' Ansell

[danakj, 2015-05-06 22:39:08]

LGTM

https://codereview.chromium.org/1126973002/diff/1/cc/trees/layer_tree_host_un...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/1126973002/diff/1/cc/trees/layer_tree_host_un...
cc/trees/layer_tree_host_unittest.cc:89: class
LayerTreeHostTestHasImplThreadTest : public LayerTreeHostTest {
while i like tests that test themselves, i don't know that we need tests to test
the test harness. i'd be rather ok without adding this test with the change. :)

https://codereview.chromium.org/1126973002/diff/1/cc/trees/layer_tree_host_un...
cc/trees/layer_tree_host_unittest.cc:111:
SINGLE_AND_MULTI_THREAD_IMPL_TEST_F(LayerTreeHostTestHasImplThreadTest);
whitespace after class defn

[mithro-old, 2015-05-06 23:24:39]

The CQ bit was checked by mithro@mithis.com

[mithro-old, 2015-05-06 23:24:40]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org
Link to the patchset: https://codereview.chromium.org/1126973002/#ps20001
(title: "Rebasing for landing.")

[mithro-old, 2015-05-06 23:24:44]

https://codereview.chromium.org/1126973002/diff/1/cc/trees/layer_tree_host_un...
File cc/trees/layer_tree_host_unittest.cc (right):

https://codereview.chromium.org/1126973002/diff/1/cc/trees/layer_tree_host_un...
cc/trees/layer_tree_host_unittest.cc:111:
SINGLE_AND_MULTI_THREAD_IMPL_TEST_F(LayerTreeHostTestHasImplThreadTest);
On 2015/05/06 22:39:08, danakj wrote:
> whitespace after class defn

Done.

[commit-bot: I haz the power, 2015-05-06 23:25:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1126973002/20001

[commit-bot: I haz the power, 2015-05-07 00:44:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-07 00:46:19]

Patchset 2 (id:??) landed as
https://crrev.com/e88f9dd1cf36789957044409e97e63987c23307c
Cr-Commit-Position: refs/heads/master@{#328667}