Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1005)

Unified Diff: content/renderer/gpu/frame_swap_message_queue_unittest.cc

Issue 1126963006: Move VISUAL_STATE promise to activation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update documentation Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/frame_swap_message_queue_unittest.cc
diff --git a/content/renderer/gpu/frame_swap_message_queue_unittest.cc b/content/renderer/gpu/frame_swap_message_queue_unittest.cc
index dc802c0e33c7748c278b6caf80d5969b2c3273e8..8ed62d0182ad8db2c36a4f04d808044182848f4a 100644
--- a/content/renderer/gpu/frame_swap_message_queue_unittest.cc
+++ b/content/renderer/gpu/frame_swap_message_queue_unittest.cc
@@ -47,6 +47,7 @@ class FrameSwapMessageQueueTest : public testing::Test {
void DrainMessages(int source_frame_number,
ScopedVector<IPC::Message>* messages) {
messages->clear();
+ queue_->DidActivate(source_frame_number);
queue_->DidSwap(source_frame_number);
scoped_ptr<FrameSwapMessageQueue::SendMessageScope> send_message_scope =
queue_->AcquireSendMessageScope();
@@ -92,6 +93,7 @@ TEST_F(FrameSwapMessageQueueTest, TestEmpty) {
ASSERT_TRUE(queue_->Empty());
QueueVisualStateMessage(1, CloneMessage(first_message_));
ASSERT_FALSE(queue_->Empty());
+ queue_->DidActivate(1);
queue_->DidSwap(1);
ASSERT_FALSE(queue_->Empty());
}
@@ -281,6 +283,7 @@ TEST_F(FrameSwapMessageQueueTest, TestDeletesQueuedVisualStateMessage) {
QueueVisualStateMessage(1,
make_scoped_ptr(new NotifiesDeletionMessage(
&message_deleted, first_message_)));
+ queue_->DidActivate(1);
queue_->DidSwap(1);
queue_ = NULL;
ASSERT_TRUE(message_deleted);

Powered by Google App Engine
This is Rietveld 408576698