Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1688)

Unified Diff: content/renderer/gpu/queue_message_swap_promise.cc

Issue 1126963006: Move VISUAL_STATE promise to activation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Current state (presubmit warnings, cc_unittests tests failing) Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/gpu/queue_message_swap_promise.cc
diff --git a/content/renderer/gpu/queue_message_swap_promise.cc b/content/renderer/gpu/queue_message_swap_promise.cc
index c8abf8994410dfd248b0eac80d237fa2b7534a64..d0330544cd6ad1c6088965173c33c87c893c6904 100644
--- a/content/renderer/gpu/queue_message_swap_promise.cc
+++ b/content/renderer/gpu/queue_message_swap_promise.cc
@@ -4,25 +4,17 @@
#include "content/renderer/gpu/queue_message_swap_promise.h"
-#include "content/renderer/gpu/frame_swap_message_queue.h"
+#include "content/renderer/gpu/frame_update_message_queue.h"
+#include "ipc/ipc_message.h"
#include "ipc/ipc_sync_message_filter.h"
namespace content {
QueueMessageSwapPromise::QueueMessageSwapPromise(
scoped_refptr<IPC::SyncMessageFilter> message_sender,
- scoped_refptr<content::FrameSwapMessageQueue> message_queue,
+ scoped_refptr<content::FrameUpdateMessageQueue> message_queue,
int source_frame_number)
- : message_sender_(message_sender),
- message_queue_(message_queue),
- source_frame_number_(source_frame_number)
-#if DCHECK_IS_ON()
- ,
- completed_(false)
-#endif
-{
- DCHECK(message_sender_.get());
- DCHECK(message_queue_.get());
+ : QueueMessagePromise(message_sender, message_queue, source_frame_number) {
}
QueueMessageSwapPromise::~QueueMessageSwapPromise() {
@@ -41,27 +33,16 @@ void QueueMessageSwapPromise::DidSwap(cc::CompositorFrameMetadata* metadata) {
PromiseCompleted();
}
-void QueueMessageSwapPromise::DidNotSwap(DidNotSwapReason reason) {
+void QueueMessageSwapPromise::DidNotSwap(DidNotSwap::Reason reason) {
#if DCHECK_IS_ON()
DCHECK(!completed_);
#endif
ScopedVector<IPC::Message> messages;
message_queue_->DidNotSwap(source_frame_number_, reason, &messages);
- for (ScopedVector<IPC::Message>::iterator i = messages.begin();
- i != messages.end();
- ++i) {
- message_sender_->Send(*i);
- }
- messages.weak_clear();
+ DeliverMessages(&messages);
PromiseCompleted();
}
-void QueueMessageSwapPromise::PromiseCompleted() {
-#if DCHECK_IS_ON()
- completed_ = true;
-#endif
-}
-
int64 QueueMessageSwapPromise::TraceId() const {
return 0;
}

Powered by Google App Engine
This is Rietveld 408576698