components/storage_monitor/storage_monitor_linux.cc - Issue 1126963003: [components/storage_monitor] Use ThreadTaskRunnerHandle instead of LoopProxy

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/storage_monitor/storage_monitor_linux.cc

Issue 1126963003: [components/storage_monitor] Use ThreadTaskRunnerHandle instead of LoopProxy (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Review Comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/storage_monitor/storage_monitor_chromeos.cc ('k') | components/storage_monitor/storage_monitor_linux_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/storage_monitor/storage_monitor_linux.cc

diff --git a/components/storage_monitor/storage_monitor_linux.cc b/components/storage_monitor/storage_monitor_linux.cc

index 436304980d72be3af4ae3dde25cf7373ea59e04c..f866b2f5fce931319525f68b690cdb233997756f 100644

--- a/components/storage_monitor/storage_monitor_linux.cc

+++ b/components/storage_monitor/storage_monitor_linux.cc

@@ -17,6 +17,7 @@

#include "base/process/kill.h"

#include "base/process/launch.h"

#include "base/process/process.h"

+#include "base/single_thread_task_runner.h"

#include "base/stl_util.h"

#include "base/strings/string_number_conversions.h"

#include "base/strings/string_util.h"

@@ -263,10 +264,10 @@ void StorageMonitorLinux::Init() {

weak_ptr_factory_.GetWeakPtr()));

if (!media_transfer_protocol_manager_) {

- scoped_refptr<base::MessageLoopProxy> loop_proxy =

BrowserThread::GetMessageLoopProxyForThread(BrowserThread::FILE);

media_transfer_protocol_manager_.reset(

- device::MediaTransferProtocolManager::Initialize(loop_proxy));

+ device::MediaTransferProtocolManager::Initialize(

+ scoped_refptr<base::SingleThreadTaskRunner>()));

Lei Zhang 2015/05/14 18:54:38 Uh, this isn't right. Look closely.

Pranay 2015/05/15 03:44:05 Oops! I'm sorry. Thanks for pointing out, Lei.

}

media_transfer_protocol_device_observer_.reset(