chrome/browser/resources/options/chromeos/display_options.html - Issue 1126933004: Allow switching between extended and unified

Side by Side Diff: chrome/browser/resources/options/chromeos/display_options.html

Issue 1126933004: Allow switching between extended and unified (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ash/display/display_manager.h ('K') | « chrome/browser/resources/options/browser_options.js ('k') | chrome/browser/resources/options/chromeos/display_options.js » ('j') | chrome/browser/resources/options/chromeos/display_options.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <div id="display-options-page" class="page" hidden>	1 <div id="display-options-page" class="page" hidden>

2 <div class="close-button"></div>	2 <div class="close-button"></div>

3 <h1 i18n-content="displayOptionsPage"></h1>	3 <h1 i18n-content="displayOptionsPage"></h1>

4 <div class="content-area" id="display-options-content-area">	4 <div class="content-area" id="display-options-content-area">

5 <div id="display-options-displays-view-host">	5 <div id="display-options-displays-view-host">

6 </div>	6 </div>

7 <div id="display-configurations">	7 <div id="display-configurations">

8 <div id="selected-display-data-container">	8 <div id="selected-display-data-container">

9 <div id="selected-display-name"></div>	9 <div id="selected-display-name"></div>

10 <div class="selected-display-option-row">	10 <div class="selected-display-option-row">

11 <div class="selected-display-option-title"	11 <div class="selected-display-option-title"

12 i18n-content="selectedDisplayTitleOptions">	12 i18n-content="selectedDisplayTitleOptions">

13 </div>	13 </div>

14 <button id="display-options-toggle-mirroring"	14 <button id="display-options-toggle-mirroring"

15 class="display-options-button" i18n-content="startMirroring">	15 class="display-options-button" i18n-content="startMirroring">

16 </button>	16 </button>

17 <button id="display-options-set-primary"	17 <button id="display-options-set-primary"

18 class="display-options-button" i18n-content="setPrimary">	18 class="display-options-button" i18n-content="setPrimary">

	19 </button>

	20 </div>

	21 <div id="display-options-unified-desktop"

	22 class="selected-display-option-row" hidden>

	23 <div class="selected-display-option-title">
	Jun Mukai 2015/05/20 02:47:49 Can you put a comment for why this is empty? <!-- Can you put a comment for why this is empty? <!-- intentionally blank for the title column space. --> oshima 2015/05/20 06:40:01 Done. Show quoted text On 2015/05/20 02:47:49, Jun Mukai wrote: > Can you put a comment for why this is empty? > <!-- intentionally blank for the title column space. --> Done.
	24 </div>

	25 <input id="display-options-toggle-unified-desktop" type="checkbox">

	26 <span i18n-content="enableUnifiedDesktop"></span>
	Jun Mukai 2015/05/20 02:47:49 label for="display-options-toggle-unified-desktop" label for="display-options-toggle-unified-desktop" instead of span, so that clicking on the text also toggles the checkbox. oshima 2015/05/20 06:40:01 Changed to use label, although I followed the othe Show quoted text On 2015/05/20 02:47:49, Jun Mukai wrote: > label for="display-options-toggle-unified-desktop" instead of span, so that > clicking on the text also toggles the checkbox. Changed to use label, although I followed the other example as suggested by presubmit. (label for="" seems to be banned) Jun Mukai 2015/05/20 07:34:20 Oh, I didn't know that details. Enclosing by <lab Show quoted text On 2015/05/20 06:40:01, oshima wrote: > On 2015/05/20 02:47:49, Jun Mukai wrote: > > label for="display-options-toggle-unified-desktop" instead of span, so that > > clicking on the text also toggles the checkbox. > > Changed to use label, although I followed the other example as suggested by > presubmit. (label for="" seems to be banned) Oh, I didn't know that details. Enclosing by <label> looks good.
19 </div>	27 </div>

20 <div class="selected-display-option-row">	28 <div class="selected-display-option-row">

21 <div class="selected-display-option-title"	29 <div class="selected-display-option-title"

22 i18n-content="selectedDisplayTitleResolution">	30 i18n-content="selectedDisplayTitleResolution">

23 </div>	31 </div>

24 <select id="display-options-resolution-selection"	32 <select id="display-options-resolution-selection"

25 class="display-options-button">	33 class="display-options-button">

26 </select>	34 </select>

27 </div>	35 </div>

28 <div class="selected-display-option-row">	36 <div class="selected-display-option-row">

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
62 <div id="display-configuration-arrow">	70 <div id="display-configuration-arrow">

63 </div>	71 </div>

64 </div>	72 </div>

65 <div class="action-area">	73 <div class="action-area">

66 <div class="button-strip">	74 <div class="button-strip">

67 <button id="display-options-done" i18n-content="done"	75 <button id="display-options-done" i18n-content="done"

68 class="default-button"></button>	76 class="default-button"></button>

69 </div>	77 </div>

70 </div>	78 </div>

71 </div>	79 </div>

OLD	NEW