bookmarks: Rename BookmarkModelTestWithProfile to BookmarkModelTestClient.

bookmarks: Get rid of BookmarkModelTestWithProfile class.

That code has been componentized and does not interact directly
with Profile anymore. With that we were also able to move the
member functions into the unnamed namespace.

BUG=None
TEST=components_unittests --gtest_filter=*Bookmark*
R=sky@chromium.org

Committed: https://crrev.com/2b39aaf5dc7d0b0e00ce680b553f369753c0aa7e
Cr-Commit-Position: refs/heads/master@{#330116}

[tfarina, 2015-05-14 00:58:53]

https://codereview.chromium.org/1126933003/diff/1/components/bookmarks/browse...
File components/bookmarks/browser/bookmark_model_unittest.cc (right):

https://codereview.chromium.org/1126933003/diff/1/components/bookmarks/browse...
components/bookmarks/browser/bookmark_model_unittest.cc:908: class
BookmarkModelTestClient : public testing::Test {
Scott, any suggestion for a better name?

[sky, 2015-05-14 15:13:56]

https://codereview.chromium.org/1126933003/diff/1/components/bookmarks/browse...
File components/bookmarks/browser/bookmark_model_unittest.cc (right):

https://codereview.chromium.org/1126933003/diff/1/components/bookmarks/browse...
components/bookmarks/browser/bookmark_model_unittest.cc:908: class
BookmarkModelTestClient : public testing::Test {
On 2015/05/14 00:58:53, tfarina wrote:
> Scott, any suggestion for a better name?

I find your new name worse. The two functions in this class don't really need to
be member functions. They could be in an anonymous namespace. If you did that,
then there really isn't a need for this class and the tests can go from TEST_F
to TEST. You still need a name though. I would probably go with
BookmarkModelTest2.

[tfarina, 2015-05-14 23:41:18]

Scott, please take another look!

https://codereview.chromium.org/1126933003/diff/1/components/bookmarks/browse...
File components/bookmarks/browser/bookmark_model_unittest.cc (right):

https://codereview.chromium.org/1126933003/diff/1/components/bookmarks/browse...
components/bookmarks/browser/bookmark_model_unittest.cc:908: class
BookmarkModelTestClient : public testing::Test {
On 2015/05/14 15:13:56, sky wrote:
> On 2015/05/14 00:58:53, tfarina wrote:
> > Scott, any suggestion for a better name?
> 
> I find your new name worse. The two functions in this class don't really need
to
> be member functions. They could be in an anonymous namespace. If you did that,
> then there really isn't a need for this class and the tests can go from TEST_F
> to TEST. You still need a name though. I would probably go with
> BookmarkModelTest2.

Ah, that way is much better! I moved the member functions into the unnamed
namespace.

[sky, 2015-05-15 00:45:55]

LGTM

https://codereview.chromium.org/1126933003/diff/20001/components/bookmarks/br...
File components/bookmarks/browser/bookmark_model_unittest.cc (right):

https://codereview.chromium.org/1126933003/diff/20001/components/bookmarks/br...
components/bookmarks/browser/bookmark_model_unittest.cc:107: typedef
ui::TreeNodeWithValue<BookmarkNode::Type> TestNode;
typedef->using

[tfarina, 2015-05-15 16:38:22]

https://codereview.chromium.org/1126933003/diff/20001/components/bookmarks/br...
File components/bookmarks/browser/bookmark_model_unittest.cc (right):

https://codereview.chromium.org/1126933003/diff/20001/components/bookmarks/br...
components/bookmarks/browser/bookmark_model_unittest.cc:107: typedef
ui::TreeNodeWithValue<BookmarkNode::Type> TestNode;
On 2015/05/15 00:45:55, sky wrote:
> typedef->using

Done.

[tfarina, 2015-05-15 16:40:14]

The CQ bit was checked by tfarina@chromium.org

[tfarina, 2015-05-15 16:40:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1126933003/#ps40001
(title: "typedef->using")

[commit-bot: I haz the power, 2015-05-15 16:41:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1126933003/40001

[commit-bot: I haz the power, 2015-05-15 17:00:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-15 17:02:13]

Patchset 3 (id:??) landed as
https://crrev.com/2b39aaf5dc7d0b0e00ce680b553f369753c0aa7e
Cr-Commit-Position: refs/heads/master@{#330116}