Add Media Router Mojo impl code.

chrome/browser/media/router/media_router.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_H_
 #define CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_H_
 
 #include <string>
 #include <vector>
 
 #include "base/callback.h"
+#include "chrome/browser/media/router/issue.h"
 #include "chrome/browser/media/router/media_route.h"
 #include "chrome/browser/media/router/media_route_id.h"
 #include "chrome/browser/media/router/media_sink.h"
 #include "chrome/browser/media/router/media_source.h"
 
 namespace media_router {
 
+class IssuesObserver;
 class MediaRoutesObserver;
 class MediaSinksObserver;
 
-// Type of callback used in |RequestRoute()|. Callback is invoked when the
+// Type of callback used in |CreateRoute()|. Callback is invoked when the
 // route request either succeeded or failed.
 // The first argument is the route created. If the route request failed, this
 // will be a nullptr.
 // The second argument is the error string, which will be nonempty if the route
 // request failed.
 using MediaRouteResponseCallback =
     base::Callback<void(scoped_ptr<MediaRoute>, const std::string&)>;
 
 // An interface for handling resources related to media routing.
 // Responsible for registering observers for receiving sink availability
 // updates, handling route requests/responses, and operating on routes (e.g.
 // posting messages or closing).
 class MediaRouter {
  public:
   virtual ~MediaRouter() {}
 
   // Requests a media route from |source| to |sink_id|.
   // |callback| is invoked with a response indicating success or failure.
-  virtual void RequestRoute(const MediaSourceId& source,
-                            const MediaSinkId& sink_id,
-                            const MediaRouteResponseCallback& callback) = 0;
+  virtual void CreateRoute(const MediaSourceId& source,
+                           const MediaSinkId& sink_id,
+                           const MediaRouteResponseCallback& callback) = 0;
 
   // Closes the media route specified by |route_id|.
   virtual void CloseRoute(const MediaRouteId& route_id) = 0;
 
   // Posts |message| to a MediaSink connected via MediaRoute with |route_id|.
   // TODO(imcheng): Support additional data types: Blob, ArrayBuffer,
   // ArrayBufferView.
   virtual void PostMessage(const MediaRouteId& route_id,
                            const std::string& message) = 0;
 
+  // Clears the issue with the id |issue_id|.
+  virtual void ClearIssue(const Issue::IssueId& issue_id) = 0;

[imcheng (use chromium acct), 2015/05/14 21:30:13]

The name Issue::IssueId is inconsistent with the other ids. Is it possible to
have simply IssueId (which is already in media_router namespace)?

[Kevin M, 2015/05/14 22:46:35]

Making the type alias a child of Issue was suggested to us during an upstreaming
code review.

I agree that consistency is important. I'll send out a separate review that
nests RouteId et al. under their respective classes.

+
   // Receives updates from a MediaRouter instance.
   class Delegate {
    public:
     // Called when there is a message from a route.
     // |route_id|: The route ID.
     // |message|: The message.
     virtual void OnMessage(const MediaRouteId& route_id,
                            const std::string& message) = 0;
   };
 
- protected:
+  // Adds the IssuesObserver |observer|.

[imcheng (use chromium acct), 2015/05/14 21:30:13]

These two functions should go into private.

[Kevin M, 2015/05/14 22:46:34]

Done.

+  virtual void AddIssuesObserver(IssuesObserver* observer) = 0;
+
+  // Removes the IssuesObserver |observer|.
+  virtual void RemoveIssuesObserver(IssuesObserver* observer) = 0;
+
+ private:
+  friend class IssuesObserver;
   friend class MediaSinksObserver;
   friend class MediaRoutesObserver;
 
-  // The following APIs are called by MediaSinksObserver/MediaRoutesObserver
-  // and implementations of MediaRouter only.
+  // The following functions are called by IssuesObserver, MediaSinksObserver,
+  // and MediaRoutesObserver.
 
   // Registers |observer| with this MediaRouter. |observer| specifies a media
   // source and will receive updates with media sinks that are compatible with
   // that source. The initial update may happen synchronously.
   // NOTE: This class does not assume ownership of |observer|. Callers must
   // manage |observer| and make sure |UnregisterObserver()| is called
   // before the observer is destroyed.
   // Returns true if registration succeeded.
   // It is invalid to request the same observer more than once and will result
   // in undefined behavior.
@@ skipping 12 matching lines @@
   virtual bool RegisterMediaRoutesObserver(MediaRoutesObserver* observer) = 0;
 
   // Removes a previously added MediaRoutesObserver. |observer| will stop
   // receiving further updates.
   virtual void UnregisterMediaRoutesObserver(MediaRoutesObserver* observer) = 0;
 };
 
 }  // namespace media_router
 
 #endif  // CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTER_H_