Added test for the behavior of InvocationMirror and noSuchMethod.

tests/language/invocation_mirror_test.dart

Index: tests/language/invocation_mirror_test.dart
diff --git a/tests/language/invocation_mirror_test.dart b/tests/language/invocation_mirror_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..a60c4dbd853c5a40d5c1fac86eba9aa76639f906
--- /dev/null
+++ b/tests/language/invocation_mirror_test.dart
@@ -0,0 +1,164 @@
+// Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+// InvocationMirror and noSuchMethod testing.
+
+/** Class with noSuchMethod that returns the mirror */
+class N {
+  noSuchMethod(InvocationMirror m) => m;
+
+  get wut => this;
+
+  flif(int x) { Expect.fail("never get here"); }
+  flaf([int x]) { Expect.fail("never get here"); }
+  flof({int y}) { Expect.fail("never get here"); }
+
+  final int plif = 99;
+  int get plaf { Expect.fail("never get here"); return 0; }
+}
+
+/** As [N] but also implements 'call', so we can call it with wrong arguments.*/
+class C extends N {
+  call(int x) { Expect.fail("never get here"); }
+}
+
+/**
+ * Checks the data of an InvocationMirror.
+ *
+ * Call without optionals for getters, with only positional for setters,
+ * and with both optionals for everything else.
+ */
+testIM(InvocationMirror im, String name, [List positional, Map named]) {

[Mads Ager (google), 2012/10/25 12:32:19]

Write it out: testInvocationMirror?

[Lasse Reichstein Nielsen, 2012/10/25 14:12:01]

Done.

+  Expect.isTrue(im is InvocationMirror);
+  Expect.equals(name, im.methodName);
+  if (named == null) {
+    Expect.isTrue(im.isAccessor);
+    Expect.isFalse(im.isMethod);
+    if (positional == null) {
+      Expect.isTrue(im.isGetter);
+      Expect.isFalse(im.isSetter);
+      Expect.equals(null, im.positionalArguments);
+      Expect.equals(null, im.positionalArguments);
+      return;
+    }
+    Expect.isTrue(im.isSetter);
+    Expect.isFalse(im.isGetter);
+    Expect.equals(1, im.positionalArguments.length);
+    Expect.equals(positional[0], im.positionalArguments[0]);
+    Expect.equals(null, im.namedArguments);
+    return;
+  }
+  Expect.isTrue(im.isMethod);
+  Expect.isFalse(im.isAccessor);
+  Expect.isFalse(im.isSetter);
+  Expect.isFalse(im.isGetter);
+
+  Expect.equals(positional.length, im.positionalArguments.length);
+  for (int i = 0; i < positional.length; i++) {
+    Expect.equals(positional[i], im.positionalArguments[i]);
+  }
+  Expect.equals(named.length, im.namedArguments.length);
+  named.forEach((k,v) {u

[Mads Ager (google), 2012/10/25 12:32:19]

Could you add a space? (k, v) {

Also, the 'u' is a typo.

[Lasse Reichstein Nielsen, 2012/10/25 14:12:01]

Done.

+    Expect.isTrue(im.namedArguments.containsKey(k));
+    Expect.equals(v, im.namedArguments[k]);
+  });
+}
+
+isNSM(e) => e is noSuchMethodError;

[Mads Ager (google), 2012/10/25 12:32:19]

Write it out.

[Lasse Reichstein Nielsen, 2012/10/25 14:12:01]

That would be almost as long as the body, so I inlined it instead.

+
+// Test different ways that noSuchMethod can be called.
+testInvocationMirrors() {
+  var n = new N();
+  var c = new C();
+
+  // Missing property/method access.
+  testIM(n.bar, 'bar');
+  testIM(n.bar = 42, 'bar=', [42]);
+  testIM(n.bar(), 'bar', [], {});
+  testIM(n.bar(42), 'bar', [42], {});
+  testIM(n.bar(x: 42), 'bar', [], {"x": 42});
+  testIM(n.bar(37, x: 42), 'bar', [37], {"x": 42});
+  testIM((n.bar)(), 'bar', [], {});
+  testIM((n.bar)(42), 'bar', [42]);
+  testIM((n.bar)(x: 42), 'bar', [], {"x": 42});
+  testIM((n.bar)(37, x: 42), 'bar', [37], {"x": 42});
+
+  // Missing operator access.
+  testIM(n + 4, '+', [4], {});
+  testIM(n - 4, '-', [4], {});
+  testIM(-n, '+', [], {});
+  testIM(n[42], '[]', [42], {});
+  testIM(n[37] = 42, '[]=', [37, 42], {});
+
+  // Calling as function when it's not.
+  testIM(n(), 'call', [], {});
+  testIM(n(42), 'call', [42], {});
+  testIM(n(x: 42), 'call', [], {"x": 42});
+  testIM(n(37, x: 42), 'call', [37], {"x": 42});
+
+  // Calling with arguments not matching existing call method.
+  testIM(c(), 'call', [], {});
+  testIM(c(37, 42), 'call', [37, 42], {});
+  testIM(c(x: 42), 'call', [], {"x": 42});
+  testIM(c(37, x: 42), 'call', [37], {"x": 42});
+
+  // Wrong arguments to existing function.
+  testIM(n.flif(), "flif", [], {});
+  testIM(n.flif(37, 42), "flif", [37, 42], {});
+  testIM(n.flif(x: 42), "flif", [], {"x": 42});
+  testIM(n.flif(37, x: 42), "flif", [37], {"x": 42});
+  testIM(n.flif = 42, "flif=", [42]);
+
+  testIM(n.flaf(37, 42), "flaf", [37, 42], {});
+  testIM(n.flaf(x: 42), "flaf", [], {"x": 42});
+  testIM(n.flaf(37, x: 42), "flaf", [37], {"x": 42});
+  testIM(n.flaf = 42, "flaf=", [42]);
+
+  testIM(n.flof(37, 42), "flof", [37, 42], {});
+  testIM(n.flof(x: 42), "flof", [], {"x": 42});
+  testIM(n.flof(37, y: 42), "flof", [37], {"y": 42});
+  testIM(n.flof = 42, "flof=", [42]);
+
+  // Reading works.
+  Expect.isTrue(n.flif is Function);
+  Expect.isTrue(n.flaf is Function);
+  Expect.isTrue(n.flof is Function);
+
+  // Writing to read-only fields.
+  testIM(n.wut = 42, "wut=", [42]);
+  testIM(n.plif = 42, "plif=", [42]);
+  testIM(n.plaf = 42, "plaf=", [42]);
+
+  // Trick call to n.call - wut is a getter returning n again.
+  testIM(n.wut(42), "call", [42]);
+
+  // Closurizing a method means that calling it badly will not hit the
+  // original receivers noSuchMethod, only the one inherited from Object
+  // by the closure object.
+  Expect.throws(() { var x = n.flif; x(37,42); }, isNSM);

[Mads Ager (google), 2012/10/25 12:32:19]

Add space x(37, 42)?

[Lasse Reichstein Nielsen, 2012/10/25 14:12:01]

Done.

+  Expect.throws(() { var x = c.call; x(37,42); }, isNSM);

[Mads Ager (google), 2012/10/25 12:32:19]

ditto

[Lasse Reichstein Nielsen, 2012/10/25 14:12:01]

Done.

+}
+
+// Test the NoSuchMethodError thrown by different incorrect calls.
+testNoSuchMethodErrors() {
+  test(Function block) {
+    Expect.throws(block, isNSM);
+  }
+
+  var o = new Object();
+  test(() => o.bar);
+  test(() => o.bar = 42);
+  test(() => o.bar());
+  test(() => o.toString = 42);
+  test(() => o.toString(42));
+  test(() => o.toString(x: 37));
+  test(() => o.hashCode = 42);
+  test(() => o.hashCode());  // Thrown by int.noSuchMethod.
+  test(() => o());
+}
+
+main() {
+  testInvocationMirrors();
+  testNoSuchMethodErrors();
+}