Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 11269034: drive: Fix a DCHECK failure at shutdown after Drive is disabled (Closed)

Created:
8 years, 1 month ago by satorux1
Modified:
8 years, 1 month ago
Reviewers:
hashimoto
CC:
chromium-reviews, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Fix a DCHECK failure at shutdown after Drive is disabled This happens as ShutdownOnUIThread(), which sets profile_ to NULL, can be called before DispatchMountCompletedEvent() at shutdown. BUG=157611 TEST=DCHECK failure disappers. See the bug for the repro steps Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=164274

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
8 years, 1 month ago (2012-10-25 07:50:40 UTC) #1
hashimoto
lgtm
8 years, 1 month ago (2012-10-25 08:12:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/11269034/1
8 years, 1 month ago (2012-10-25 08:44:42 UTC) #3
commit-bot: I haz the power
8 years, 1 month ago (2012-10-25 09:42:59 UTC) #4
Retried try job too often for step(s) unit_tests

Powered by Google App Engine
This is Rietveld 408576698