chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc - Issue 11269022: Add Vector2d classes that represent offsets, instead of using Point.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc

Issue 11269022: Add Vector2d classes that represent offsets, instead of using Point. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: RenderText fixup Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/gtk/tabs/tab_renderer_gtk.cc ('k') | chrome/browser/ui/panels/panel_browsertest.cc » ('j') | content/public/common/common_param_traits.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc

diff --git a/chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc b/chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc

index 7db8886d5c2396e6cf78da3c409a97b46b42f49d..026f95c37c06def0a43f8f22a6331105d598a90c 100644

--- a/chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc

+++ b/chrome/browser/ui/panels/panel_and_desktop_notification_browsertest.cc

@@ -101,7 +101,7 @@ class PanelAndDesktopNotificationTest : public BasePanelBrowserTest {

static void ResizePanelByMouseWithDelta(Panel* panel,

panel::ResizingSides side,

- const gfx::Point& delta) {

+ const gfx::Vector2d& delta) {

PanelManager* panel_manager = PanelManager::GetInstance();

gfx::Point mouse_location = panel->GetBounds().origin();

panel_manager->StartResizingByMouse(panel, mouse_location, side);

@@ -308,7 +308,7 @@ IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, ResizePanelByMouse) {

// Resize the panel to make it taller. Expect that the notification balloon

// moves further up by the amount of enlarge offset.

- gfx::Point drag_delta(-50, -100);

+ gfx::Vector2d drag_delta(-50, -100);

ResizePanelByMouseWithDelta(panel, panel::RESIZE_TOP_LEFT, drag_delta);

MessageLoopForUI::current()->RunAllPending();

int balloon_bottom2 = GetBalloonBottomPosition(balloon);

@@ -316,7 +316,7 @@ IN_PROC_BROWSER_TEST_F(PanelAndDesktopNotificationTest, ResizePanelByMouse) {

// Resize the panel to make it shorter. Expect that the notification balloon

// moves down by the amount of shrink offset.

- drag_delta = gfx::Point(0, 60);

+ drag_delta = gfx::Vector2d(0, 60);

ResizePanelByMouseWithDelta(panel, panel::RESIZE_TOP, drag_delta);

MessageLoopForUI::current()->RunAllPending();

int balloon_bottom3 = GetBalloonBottomPosition(balloon);