Move fileapi and dom_storage directories into the content namespace.

Move fileapi and dom_storage directories into the content namespace.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163944

[jam, 2012-10-24 21:01:43]

(this was in progress on my machine. i leave the rest to you :) )

[tfarina, 2012-10-24 21:10:40]

On 2012/10/24 21:01:43, John Abd-El-Malek wrote:
> (this was in progress on my machine. i leave the rest to you :) )

Yay! Although, we can go faster if you also keep going with this :)

Your machine is hundreds of times faster than mine :)

https://codereview.chromium.org/11269010/diff/12003/content/browser/fileapi/c...
File content/browser/fileapi/chrome_blob_storage_context.cc (right):

https://codereview.chromium.org/11269010/diff/12003/content/browser/fileapi/c...
content/browser/fileapi/chrome_blob_storage_context.cc:16: static const char*
kBlobStorageContextKeyName = "content_blob_storage_context";
nit: const char kBlobStorageContextKeyName[] = "content_blob_storage_context";

outside of the namespace, inside a unnamed namespace, although the unnamed
namespace is not strictly necessary, since const has internal linkage in c++.

https://codereview.chromium.org/11269010/diff/12003/content/browser/renderer_...
File content/browser/renderer_host/render_message_filter.h (right):

https://codereview.chromium.org/11269010/diff/12003/content/browser/renderer_...
content/browser/renderer_host/render_message_filter.h:94:
content::BrowserThread::ID* thread) OVERRIDE;
nit: remove content:: here.

[tfarina, 2012-10-24 21:12:20]

lgtm

[jam, 2012-10-24 21:19:48]

https://codereview.chromium.org/11269010/diff/12003/content/browser/fileapi/c...
File content/browser/fileapi/chrome_blob_storage_context.cc (right):

https://codereview.chromium.org/11269010/diff/12003/content/browser/fileapi/c...
content/browser/fileapi/chrome_blob_storage_context.cc:16: static const char*
kBlobStorageContextKeyName = "content_blob_storage_context";
On 2012/10/24 21:10:40, tfarina wrote:
> nit: const char kBlobStorageContextKeyName[] = "content_blob_storage_context";
> 
> outside of the namespace, inside a unnamed namespace, although the unnamed
> namespace is not strictly necessary, since const has internal linkage in c++.

why? i think it's easier to keep all the code (including constants) inside the
namespace

https://codereview.chromium.org/11269010/diff/12003/content/browser/renderer_...
File content/browser/renderer_host/render_message_filter.h (right):

https://codereview.chromium.org/11269010/diff/12003/content/browser/renderer_...
content/browser/renderer_host/render_message_filter.h:94:
content::BrowserThread::ID* thread) OVERRIDE;
On 2012/10/24 21:10:40, tfarina wrote:
> nit: remove content:: here.

Done.

[tfarina, 2012-10-24 21:26:32]

On Wed, Oct 24, 2012 at 7:19 PM,  <jam@chromium.org> wrote:
>
https://codereview.chromium.org/11269010/diff/12003/content/browser/fileapi/c...
> content/browser/fileapi/chrome_blob_storage_context.cc:16: static const
> char* kBlobStorageContextKeyName = "content_blob_storage_context";
> On 2012/10/24 21:10:40, tfarina wrote:
>>
>> nit: const char kBlobStorageContextKeyName[] =
>
> "content_blob_storage_context";
>
>> outside of the namespace, inside a unnamed namespace, although the
>
> unnamed
>>
>> namespace is not strictly necessary, since const has internal linkage
>
> in c++.
>
> why? i think it's easier to keep all the code (including constants)
> inside the namespace
>
yep, I think it's fine as:

namespace content {

const char kFoo[] = "...";

}  // namespace content

$ nm -C namespace-const.o

Will show no external references, so we are safe.

-- 
Thiago